[Python-checkins] bpo-33182: Fix pointer types in _testembed (GH-6310)

Nick Coghlan webhook-mailer at python.org
Fri Mar 30 01:36:52 EDT 2018


https://github.com/python/cpython/commit/69f5c73311a61b05485b19626935bf240ad31c5b
commit: 69f5c73311a61b05485b19626935bf240ad31c5b
branch: master
author: Nick Coghlan <ncoghlan at gmail.com>
committer: GitHub <noreply at github.com>
date: 2018-03-30T15:36:42+10:00
summary:

bpo-33182: Fix pointer types in _testembed (GH-6310)

files:
A Misc/NEWS.d/next/Build/2018-03-30-14-55-48.bpo-33182.CePczb.rst
M Programs/_testembed.c

diff --git a/Misc/NEWS.d/next/Build/2018-03-30-14-55-48.bpo-33182.CePczb.rst b/Misc/NEWS.d/next/Build/2018-03-30-14-55-48.bpo-33182.CePczb.rst
new file mode 100644
index 000000000000..6310e5d5b557
--- /dev/null
+++ b/Misc/NEWS.d/next/Build/2018-03-30-14-55-48.bpo-33182.CePczb.rst
@@ -0,0 +1 @@
+The embedding tests can once again be built with clang 6.0
diff --git a/Programs/_testembed.c b/Programs/_testembed.c
index 09b7bf6d94fc..7406470ae65c 100644
--- a/Programs/_testembed.c
+++ b/Programs/_testembed.c
@@ -166,16 +166,18 @@ static int test_pre_initialization_api(void)
 /* bpo-33042: Ensure embedding apps can predefine sys module options */
 static int test_pre_initialization_sys_options(void)
 {
-    /* We allocate a couple of the option dynamically, and then delete
+    /* We allocate a couple of the options dynamically, and then delete
      * them before calling Py_Initialize. This ensures the interpreter isn't
      * relying on the caller to keep the passed in strings alive.
      */
-    wchar_t *static_warnoption = L"once";
-    wchar_t *static_xoption = L"also_not_an_option=2";
+    const wchar_t *static_warnoption = L"once";
+    const wchar_t *static_xoption = L"also_not_an_option=2";
     size_t warnoption_len = wcslen(static_warnoption);
     size_t xoption_len = wcslen(static_xoption);
-    wchar_t *dynamic_once_warnoption = calloc(warnoption_len+1, sizeof(wchar_t));
-    wchar_t *dynamic_xoption = calloc(xoption_len+1, sizeof(wchar_t));
+    wchar_t *dynamic_once_warnoption = \
+             (wchar_t *) calloc(warnoption_len+1, sizeof(wchar_t));
+    wchar_t *dynamic_xoption = \
+             (wchar_t *) calloc(xoption_len+1, sizeof(wchar_t));
     wcsncpy(dynamic_once_warnoption, static_warnoption, warnoption_len+1);
     wcsncpy(dynamic_xoption, static_xoption, xoption_len+1);
 



More information about the Python-checkins mailing list