[Python-checkins] bpo-33629: Prevent coredump in test_importlib (GH-7090)

Miss Islington (bot) webhook-mailer at python.org
Thu May 24 16:45:00 EDT 2018


https://github.com/python/cpython/commit/d9eb22c67c38b45764dd924801c72092770d200f
commit: d9eb22c67c38b45764dd924801c72092770d200f
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-05-24T13:44:56-07:00
summary:

bpo-33629: Prevent coredump in test_importlib (GH-7090)


bpo-32374, bpo-33629: Use support.SuppressCrashReport() in
test_bad_traverse() of MultiPhaseExtensionModuleTests to prevent
leaking a core dump file.
(cherry picked from commit 483000e164ec68717d335767b223ae31b4b720cf)

Co-authored-by: Victor Stinner <vstinner at redhat.com>

files:
M Lib/test/test_importlib/extension/test_loader.py

diff --git a/Lib/test/test_importlib/extension/test_loader.py b/Lib/test/test_importlib/extension/test_loader.py
index 53ac3c71d4b5..57ba7083d37d 100644
--- a/Lib/test/test_importlib/extension/test_loader.py
+++ b/Lib/test/test_importlib/extension/test_loader.py
@@ -275,10 +275,13 @@ def test_bad_traverse(self):
             (Multiphase initialization modules only)
         '''
         script = """if True:
+                from test import support
                 import importlib.util as util
                 spec = util.find_spec('_testmultiphase')
                 spec.name = '_testmultiphase_with_bad_traverse'
-                m = spec.loader.create_module(spec)"""
+
+                with support.SuppressCrashReport():
+                    m = spec.loader.create_module(spec)"""
         assert_python_failure("-c", script)
 
 



More information about the Python-checkins mailing list