[Python-checkins] bpo-32374: Ignore Python-level exceptions in test_bad_traverse (GH-7145) (GH-7150)

Petr Viktorin webhook-mailer at python.org
Mon May 28 08:52:09 EDT 2018


https://github.com/python/cpython/commit/983c1ba94aef945386001932c5744f8ce9757fec
commit: 983c1ba94aef945386001932c5744f8ce9757fec
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: Petr Viktorin <encukou at gmail.com>
date: 2018-05-28T14:52:03+02:00
summary:

bpo-32374: Ignore Python-level exceptions in test_bad_traverse (GH-7145) (GH-7150)

(cherry picked from commit 08c5aca9d13b24b35faf89ebd26fc348ae1731b2)

Co-authored-by: Marcel Plch <gmarcel.plch at gmail.com>

files:
M Lib/test/test_importlib/extension/test_loader.py

diff --git a/Lib/test/test_importlib/extension/test_loader.py b/Lib/test/test_importlib/extension/test_loader.py
index 57ba7083d37d..9ad05fadef29 100644
--- a/Lib/test/test_importlib/extension/test_loader.py
+++ b/Lib/test/test_importlib/extension/test_loader.py
@@ -275,13 +275,19 @@ def test_bad_traverse(self):
             (Multiphase initialization modules only)
         '''
         script = """if True:
-                from test import support
-                import importlib.util as util
-                spec = util.find_spec('_testmultiphase')
-                spec.name = '_testmultiphase_with_bad_traverse'
-
-                with support.SuppressCrashReport():
-                    m = spec.loader.create_module(spec)"""
+                try:
+                    from test import support
+                    import importlib.util as util
+                    spec = util.find_spec('_testmultiphase')
+                    spec.name = '_testmultiphase_with_bad_traverse'
+
+                    with support.SuppressCrashReport():
+                        m = spec.loader.create_module(spec)
+                except:
+                    # Prevent Python-level exceptions from
+                    # ending the process with non-zero status
+                    # (We are testing for a crash in C-code)
+                    pass"""
         assert_python_failure("-c", script)
 
 



More information about the Python-checkins mailing list