[Python-checkins] Fix the construction of subprocess.CalledProcessError in test_venv (GH-10400)

Miss Islington (bot) webhook-mailer at python.org
Wed Nov 7 17:39:26 EST 2018

commit: b097f9fe2b359f8b64c030db51cfa2930c26971b
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-11-07T14:39:21-08:00

Fix the construction of subprocess.CalledProcessError in test_venv (GH-10400)

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b93925047a025511c48a7bf3e6e6f0cfec79b8ed)

Co-authored-by: Pablo Galindo <Pablogsal at gmail.com>

M Lib/test/test_venv.py

diff --git a/Lib/test/test_venv.py b/Lib/test/test_venv.py
index c86f7a1a07ae..461fe7afd213 100644
--- a/Lib/test/test_venv.py
+++ b/Lib/test/test_venv.py
@@ -35,7 +35,7 @@ def check_output(cmd, encoding=None):
     out, err = p.communicate()
     if p.returncode:
         raise subprocess.CalledProcessError(
-            p.returncode, cmd, None, out, err)
+            p.returncode, cmd, out, err)
     return out, err
 class BaseTest(unittest.TestCase):

More information about the Python-checkins mailing list