[Python-checkins] Disable getc_unlocked() with MemorySanitizer. (GH-10499)
Miss Islington (bot)
webhook-mailer at python.org
Mon Nov 12 22:59:32 EST 2018
https://github.com/python/cpython/commit/f0b21e18d8398f010707c3c199f97d8466214dd6
commit: f0b21e18d8398f010707c3c199f97d8466214dd6
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-11-12T19:59:29-08:00
summary:
Disable getc_unlocked() with MemorySanitizer. (GH-10499)
clang's MemorySanitizer understand getc() but does not understand
getc_unlocked(). Workaround: Don't use it on msan builds.
(cherry picked from commit e6c77d8301ec1703abb755a7d3ce5bd8c999c082)
Co-authored-by: Gregory P. Smith <greg at krypto.org>
files:
M Objects/fileobject.c
diff --git a/Objects/fileobject.c b/Objects/fileobject.c
index 0f71944d526e..a49194ef6c38 100644
--- a/Objects/fileobject.c
+++ b/Objects/fileobject.c
@@ -3,7 +3,8 @@
#define PY_SSIZE_T_CLEAN
#include "Python.h"
-#ifdef HAVE_GETC_UNLOCKED
+#if defined(HAVE_GETC_UNLOCKED) && !defined(MEMORY_SANITIZER)
+/* clang MemorySanitizer doesn't yet understand getc_unlocked. */
#define GETC(f) getc_unlocked(f)
#define FLOCKFILE(f) flockfile(f)
#define FUNLOCKFILE(f) funlockfile(f)
More information about the Python-checkins
mailing list