[Python-checkins] bpo-35356: Fix a possible reference leak in nis.maps(). (GH-10808)

Miss Islington (bot) webhook-mailer at python.org
Fri Nov 30 03:00:10 EST 2018


https://github.com/python/cpython/commit/e604b6c53e7dce6d4cf52525f4ae57352d489cba
commit: e604b6c53e7dce6d4cf52525f4ae57352d489cba
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-11-30T00:00:07-08:00
summary:

bpo-35356: Fix a possible reference leak in nis.maps(). (GH-10808)

(cherry picked from commit a2e3585e79c93b2372dbad46a744e28fcc6dad6d)

Co-authored-by: Zackery Spytz <zspytz at gmail.com>

files:
M Modules/nismodule.c

diff --git a/Modules/nismodule.c b/Modules/nismodule.c
index a9028bbfe54c..11df679b745b 100644
--- a/Modules/nismodule.c
+++ b/Modules/nismodule.c
@@ -412,6 +412,7 @@ nis_maps (PyObject *self, PyObject *args, PyObject *kwdict)
         PyObject *str = PyUnicode_FromString(maps->map);
         if (!str || PyList_Append(list, str) < 0)
         {
+            Py_XDECREF(str);
             Py_DECREF(list);
             list = NULL;
             break;



More information about the Python-checkins mailing list