[Python-checkins] bpo-34879: Fix a possible null pointer dereference in bytesobject.c (GH-9683)

Miss Islington (bot) webhook-mailer at python.org
Wed Oct 3 02:33:46 EDT 2018

commit: 063755c20184e80f587d522600536d1ba70a5f7e
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-10-02T23:33:42-07:00

bpo-34879: Fix a possible null pointer dereference in bytesobject.c (GH-9683)

formatfloat() was not checking if PyBytes_FromStringAndSize()
failed, which could lead to a null pointer dereference in
(cherry picked from commit 96c593279400693226d5a560c420ae0fcf1731b9)

Co-authored-by: Zackery Spytz <zspytz at gmail.com>

A Misc/NEWS.d/next/Core and Builtins/2018-10-02-22-55-11.bpo-34879.7VNH2a.rst
M Objects/bytesobject.c

diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-10-02-22-55-11.bpo-34879.7VNH2a.rst b/Misc/NEWS.d/next/Core and Builtins/2018-10-02-22-55-11.bpo-34879.7VNH2a.rst
new file mode 100644
index 000000000000..5775a219a273
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2018-10-02-22-55-11.bpo-34879.7VNH2a.rst	
@@ -0,0 +1,2 @@
+Fix a possible null pointer dereference in bytesobject.c.  Patch by Zackery
diff --git a/Objects/bytesobject.c b/Objects/bytesobject.c
index 82a75457708b..32ff5afe3e02 100644
--- a/Objects/bytesobject.c
+++ b/Objects/bytesobject.c
@@ -448,7 +448,7 @@ formatfloat(PyObject *v, int flags, int prec, int type,
     result = PyBytes_FromStringAndSize(p, len);
     *p_result = result;
-    return str;
+    return result != NULL ? str : NULL;
 static PyObject *

More information about the Python-checkins mailing list