[Python-checkins] Fix an incorrect check in compiler_try_except(). (GH-9810)

Miss Islington (bot) webhook-mailer at python.org
Fri Oct 12 03:19:24 EDT 2018


https://github.com/python/cpython/commit/72927d0d1787809b4b25e5086c5a9167bdb807bb
commit: 72927d0d1787809b4b25e5086c5a9167bdb807bb
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-10-12T00:19:20-07:00
summary:

Fix an incorrect check in compiler_try_except(). (GH-9810)

(cherry picked from commit 53ebf4b0709f431b7262aa5daccef7eafde7383e)

Co-authored-by: Zackery Spytz <zspytz at gmail.com>

files:
M Python/compile.c

diff --git a/Python/compile.c b/Python/compile.c
index b459096c6f00..3564ca2b904f 100644
--- a/Python/compile.c
+++ b/Python/compile.c
@@ -2670,8 +2670,9 @@ compiler_try_except(struct compiler *c, stmt_ty s)
 
             cleanup_end = compiler_new_block(c);
             cleanup_body = compiler_new_block(c);
-            if (!(cleanup_end || cleanup_body))
+            if (cleanup_end == NULL || cleanup_body == NULL) {
                 return 0;
+            }
 
             compiler_nameop(c, handler->v.ExceptHandler.name, Store);
             ADDOP(c, POP_TOP);



More information about the Python-checkins mailing list