[Python-checkins] bpo-35086: Fix tkinter example "A Simple Hello World Program". (GH-10160)
Miss Islington (bot)
webhook-mailer at python.org
Tue Oct 30 11:34:59 EDT 2018
https://github.com/python/cpython/commit/f51ef51db686938486bff453e791a3093a1df108
commit: f51ef51db686938486bff453e791a3093a1df108
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-10-30T08:34:54-07:00
summary:
bpo-35086: Fix tkinter example "A Simple Hello World Program". (GH-10160)
The root widget was accessed as a global variable in the Application's method.
(cherry picked from commit a80af770870937271865b5e2b05a2cfe40b024b6)
Co-authored-by: Daniel Lovell <lovell.daniel92 at gmail.com>
files:
M Doc/library/tkinter.rst
diff --git a/Doc/library/tkinter.rst b/Doc/library/tkinter.rst
index 4af4b7356e1c..60cf892e0888 100644
--- a/Doc/library/tkinter.rst
+++ b/Doc/library/tkinter.rst
@@ -205,6 +205,7 @@ A Simple Hello World Program
class Application(tk.Frame):
def __init__(self, master=None):
super().__init__(master)
+ self.master = master
self.pack()
self.create_widgets()
@@ -215,7 +216,7 @@ A Simple Hello World Program
self.hi_there.pack(side="top")
self.quit = tk.Button(self, text="QUIT", fg="red",
- command=root.destroy)
+ command=self.master.destroy)
self.quit.pack(side="bottom")
def say_hi(self):
More information about the Python-checkins
mailing list