[Python-checkins] closes bpo-34664: Only check file permission bits of newly created directories. (GH-9273)

Benjamin Peterson webhook-mailer at python.org
Thu Sep 13 15:00:19 EDT 2018


https://github.com/python/cpython/commit/84db4a9978069a98978e9cd7951d1a01d47e5286
commit: 84db4a9978069a98978e9cd7951d1a01d47e5286
branch: master
author: Benjamin Peterson <benjamin at python.org>
committer: GitHub <noreply at github.com>
date: 2018-09-13T12:00:14-07:00
summary:

closes bpo-34664: Only check file permission bits of newly created directories. (GH-9273)

files:
M Lib/test/test_os.py

diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
index 0a8ba5cf95f1..6dbc25561237 100644
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -1131,8 +1131,8 @@ def test_mode(self):
             self.assertTrue(os.path.exists(path))
             self.assertTrue(os.path.isdir(path))
             if os.name != 'nt':
-                self.assertEqual(stat.S_IMODE(os.stat(path).st_mode), 0o555)
-                self.assertEqual(stat.S_IMODE(os.stat(parent).st_mode), 0o775)
+                self.assertEqual(os.stat(path).st_mode & 0o777, 0o555)
+                self.assertEqual(os.stat(parent).st_mode & 0o777, 0o775)
 
     def test_exist_ok_existing_directory(self):
         path = os.path.join(support.TESTFN, 'dir1')



More information about the Python-checkins mailing list