[Python-checkins] Have UserDict.__init__() implicitly check for updating w/ bool(kwargs) instead of len() (GH-12139)

Miss Islington (bot) webhook-mailer at python.org
Tue Apr 2 17:47:53 EDT 2019


https://github.com/python/cpython/commit/76b387bf7402863c5e64e3459e2f91ddc3b9d2d3
commit: 76b387bf7402863c5e64e3459e2f91ddc3b9d2d3
branch: master
author: Slam <3lnc.slam at gmail.com>
committer: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
date: 2019-04-02T14:47:41-07:00
summary:

Have UserDict.__init__() implicitly check for updating w/ bool(kwargs) instead of len() (GH-12139)



Semantically the same, but more idiomatic by checking against `kwargs` instead of `len(kwargs)`.

files:
M Lib/collections/__init__.py

diff --git a/Lib/collections/__init__.py b/Lib/collections/__init__.py
index cff75a48d627..9657c1cf83bc 100644
--- a/Lib/collections/__init__.py
+++ b/Lib/collections/__init__.py
@@ -1016,7 +1016,7 @@ def __init__(*args, **kwargs):
         self.data = {}
         if dict is not None:
             self.update(dict)
-        if len(kwargs):
+        if kwargs:
             self.update(kwargs)
     def __len__(self): return len(self.data)
     def __getitem__(self, key):



More information about the Python-checkins mailing list