[Python-checkins] bpo-36560: regrtest: don't collect the GC twice (GH-12747)
Victor Stinner
webhook-mailer at python.org
Tue Apr 9 12:26:22 EDT 2019
https://github.com/python/cpython/commit/bb4447897a5f141eecf42987a1191a3330c5d7ed
commit: bb4447897a5f141eecf42987a1191a3330c5d7ed
branch: master
author: Victor Stinner <vstinner at redhat.com>
committer: GitHub <noreply at github.com>
date: 2019-04-09T18:26:16+02:00
summary:
bpo-36560: regrtest: don't collect the GC twice (GH-12747)
dash_R() function of libregrtest doesn't call support.gc_collect()
directly anymore: it's already called by dash_R_cleanup().
Call dash_R_cleanup() before starting the loop.
files:
M Lib/test/libregrtest/refleak.py
diff --git a/Lib/test/libregrtest/refleak.py b/Lib/test/libregrtest/refleak.py
index 0bb8a0a2bf08..235d6bfd3af6 100644
--- a/Lib/test/libregrtest/refleak.py
+++ b/Lib/test/libregrtest/refleak.py
@@ -82,12 +82,14 @@ def get_pooled_int(value):
print(("1234567890"*(repcount//10 + 1))[:repcount], file=sys.stderr,
flush=True)
+ dash_R_cleanup(fs, ps, pic, zdc, abcs)
+
for i in rep_range:
test_func()
dash_R_cleanup(fs, ps, pic, zdc, abcs)
- # Collect cyclic trash and read memory statistics immediately after.
- support.gc_collect()
+ # dash_R_cleanup() ends with collecting cyclic trash:
+ # read memory statistics immediately after.
alloc_after = getallocatedblocks()
rc_after = gettotalrefcount()
fd_after = fd_count()
More information about the Python-checkins
mailing list