[Python-checkins] bpo-36577: setup.py reports missing OpenSSL again (GH-12746)

[Miss Islington (bot)]

https://github.com/python/cpython/commit/8abc3f4f91e6b523c761c7a6fa2e3405019803a1
commit: 8abc3f4f91e6b523c761c7a6fa2e3405019803a1
branch: master
author: Christian Heimes <christian at python.org>
committer: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
date: 2019-04-09T09:40:12-07:00
summary:

bpo-36577: setup.py reports missing OpenSSL again (GH-12746)



[bpo-36146](https://bugs.python.org/issue36146) introduced another regression. In case of missing OpenSSL
libraries or headers, setup.py no longer reported _hashlib and _ssl to
be missing.

Signed-off-by: Christian Heimes <christian at python.org>



https://bugs.python.org/issue36577

files:
A Misc/NEWS.d/next/Build/2019-04-09-17-31-47.bpo-36577.34kuUW.rst
M setup.py

diff --git a/Misc/NEWS.d/next/Build/2019-04-09-17-31-47.bpo-36577.34kuUW.rst b/Misc/NEWS.d/next/Build/2019-04-09-17-31-47.bpo-36577.34kuUW.rst
new file mode 100644
index 000000000000..58c015127309
--- /dev/null
+++ b/Misc/NEWS.d/next/Build/2019-04-09-17-31-47.bpo-36577.34kuUW.rst
@@ -0,0 +1 @@
+setup.py now correctly reports missing OpenSSL headers and libraries again.
diff --git a/setup.py b/setup.py
index 85c706cf6610..30caed5b51c1 100644
--- a/setup.py
+++ b/setup.py
@@ -2153,6 +2153,7 @@ def split_var(name, sep):
         openssl_libs = split_var('OPENSSL_LIBS', '-l')
         if not openssl_libs:
             # libssl and libcrypto not found
+            self.missing.extend(['_ssl', '_hashlib'])
             return None, None
 
         # Find OpenSSL includes
@@ -2160,6 +2161,7 @@ def split_var(name, sep):
             'openssl/ssl.h', self.inc_dirs, openssl_includes
         )
         if ssl_incs is None:
+            self.missing.extend(['_ssl', '_hashlib'])
             return None, None
 
         # OpenSSL 1.0.2 uses Kerberos for KRB5 ciphers