[Python-checkins] bpo-36597: fix random doctest failure (GH-12776)

Inada Naoki webhook-mailer at python.org
Thu Apr 11 04:53:54 EDT 2019


https://github.com/python/cpython/commit/57b1a2862a99677f09614e9e456d36aae9ddd87c
commit: 57b1a2862a99677f09614e9e456d36aae9ddd87c
branch: master
author: Inada Naoki <songofacandy at gmail.com>
committer: GitHub <noreply at github.com>
date: 2019-04-11T17:53:49+09:00
summary:

bpo-36597: fix random doctest failure (GH-12776)

files:
M .travis.yml
M Doc/library/weakref.rst

diff --git a/.travis.yml b/.travis.yml
index 23f79d0c3766..6d57ebb1d2fb 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -56,22 +56,20 @@ matrix:
         - python -m pip install sphinx==1.8.2 blurb python-docs-theme
       script:
         - make check suspicious html SPHINXOPTS="-q -W -j4"
-    # FIXME: bpo-36597: the doctest job fails because it fails
-    # FIXME: for an unknown reason
-    #- os: linux
-    #  language: c
-    #  compiler: clang
-    #  env: TESTING=doctest
-    #  addons:
-    #    apt:
-    #      packages:
-    #        - xvfb
-    #  before_script:
-    #    - ./configure
-    #    - make -j4
-    #    - make -C Doc/ PYTHON=../python venv
-    #  script:
-    #    xvfb-run make -C Doc/ PYTHON=../python SPHINXOPTS="-q -W -j4" doctest
+    - os: linux
+      language: c
+      compiler: clang
+      env: TESTING=doctest
+      addons:
+        apt:
+          packages:
+            - xvfb
+      before_script:
+        - ./configure
+        - make -j4
+        - make -C Doc/ PYTHON=../python venv
+      script:
+        xvfb-run make -C Doc/ PYTHON=../python SPHINXOPTS="-q -W -j4" doctest
     - os: osx
       language: c
       compiler: clang
diff --git a/Doc/library/weakref.rst b/Doc/library/weakref.rst
index 40bb06adfd44..b9e887cab5d1 100644
--- a/Doc/library/weakref.rst
+++ b/Doc/library/weakref.rst
@@ -492,7 +492,7 @@ is still alive.  For instance
     >>> obj = Object()
     >>> weakref.finalize(obj, print, "obj dead or exiting")  #doctest:+ELLIPSIS
     <finalize object at ...; for 'Object' at ...>
-    >>> exit()                                               #doctest:+SKIP
+    >>> del obj
     obj dead or exiting
 
 



More information about the Python-checkins mailing list