[Python-checkins] bpo-36678: Rename duplicate tests in test_dataclasses (GH-12899)

Steve Dower webhook-mailer at python.org
Mon Apr 22 14:45:41 EDT 2019


https://github.com/python/cpython/commit/be372d73b4c59026134a7e722ece34367c3bd3b6
commit: be372d73b4c59026134a7e722ece34367c3bd3b6
branch: master
author: Windson yang <wiwindson at outlook.com>
committer: Steve Dower <steve.dower at microsoft.com>
date: 2019-04-22T11:45:34-07:00
summary:

bpo-36678: Rename duplicate tests in test_dataclasses (GH-12899)

files:
M Lib/test/test_dataclasses.py

diff --git a/Lib/test/test_dataclasses.py b/Lib/test/test_dataclasses.py
index 9c83459f09e7..d320a969876e 100755
--- a/Lib/test/test_dataclasses.py
+++ b/Lib/test/test_dataclasses.py
@@ -697,7 +697,7 @@ class C:
             y: int
         self.assertNotEqual(Point(1, 3), C(1, 3))
 
-    def test_not_tuple(self):
+    def test_not_other_dataclass(self):
         # Test that some of the problems with namedtuple don't happen
         #  here.
         @dataclass
@@ -1403,7 +1403,7 @@ class GroupDict:
         self.assertEqual(asdict(gd), {'id': 0, 'users': {'first': {'name': 'Alice', 'id': 1},
                                                          'second': {'name': 'Bob', 'id': 2}}})
 
-    def test_helper_asdict_builtin_containers(self):
+    def test_helper_asdict_builtin_object_containers(self):
         @dataclass
         class Child:
             d: object
@@ -1576,7 +1576,7 @@ class GroupDict:
         self.assertEqual(astuple(gt), (0, (('Alice', 1), ('Bob', 2))))
         self.assertEqual(astuple(gd), (0, {'first': ('Alice', 1), 'second': ('Bob', 2)}))
 
-    def test_helper_astuple_builtin_containers(self):
+    def test_helper_astuple_builtin_object_containers(self):
         @dataclass
         class Child:
             d: object
@@ -3242,18 +3242,6 @@ class E:
                                   ".<locals>.D(f=TestReplace.test_recursive_repr_indirection_two"
                                   ".<locals>.E(f=...)))")
 
-    def test_recursive_repr_two_attrs(self):
-        @dataclass
-        class C:
-            f: "C"
-            g: "C"
-
-        c = C(None, None)
-        c.f = c
-        c.g = c
-        self.assertEqual(repr(c), "TestReplace.test_recursive_repr_two_attrs"
-                                  ".<locals>.C(f=..., g=...)")
-
     def test_recursive_repr_misc_attrs(self):
         @dataclass
         class C:



More information about the Python-checkins mailing list