[Python-checkins] bpo-35946: Improve assert_called_with documentation (GH-11796)

Ned Deily webhook-mailer at python.org
Thu Aug 29 02:15:57 EDT 2019


https://github.com/python/cpython/commit/f5896a05edf5df91fb1b55bd481ba5b2a3682f4e
commit: f5896a05edf5df91fb1b55bd481ba5b2a3682f4e
branch: master
author: Rémi Lapeyre <remi.lapeyre at henki.fr>
committer: Ned Deily <nad at python.org>
date: 2019-08-29T02:15:53-04:00
summary:

bpo-35946: Improve assert_called_with documentation (GH-11796)

files:
M Doc/library/unittest.mock.rst
M Lib/unittest/mock.py

diff --git a/Doc/library/unittest.mock.rst b/Doc/library/unittest.mock.rst
index 19e9715102bf..304ba532274d 100644
--- a/Doc/library/unittest.mock.rst
+++ b/Doc/library/unittest.mock.rst
@@ -317,8 +317,8 @@ the *new_callable* argument to :func:`patch`.
 
     .. method:: assert_called_with(*args, **kwargs)
 
-        This method is a convenient way of asserting that calls are made in a
-        particular way:
+        This method is a convenient way of asserting that the last call has been
+        made in a particular way:
 
             >>> mock = Mock()
             >>> mock.method(1, 2, 3, test='wow')
diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py
index 5846eeb404d2..c6771ce5291a 100644
--- a/Lib/unittest/mock.py
+++ b/Lib/unittest/mock.py
@@ -888,7 +888,7 @@ def assert_called_once(self):
             raise AssertionError(msg)
 
     def assert_called_with(self, /, *args, **kwargs):
-        """assert that the mock was called with the specified arguments.
+        """assert that the last call was made with the specified arguments.
 
         Raises an AssertionError if the args and keyword args passed in are
         different to the last call to the mock."""



More information about the Python-checkins mailing list