[Python-checkins] Fix error when running with -uall in test_unparse (GH-17739)
Pablo Galindo
webhook-mailer at python.org
Sun Dec 29 15:18:40 EST 2019
https://github.com/python/cpython/commit/be287c319124b7eb59ef32b69cf837ae3e99acab
commit: be287c319124b7eb59ef32b69cf837ae3e99acab
branch: master
author: Pablo Galindo <Pablogsal at gmail.com>
committer: GitHub <noreply at github.com>
date: 2019-12-29T20:18:36Z
summary:
Fix error when running with -uall in test_unparse (GH-17739)
files:
M Lib/test/test_unparse.py
diff --git a/Lib/test/test_unparse.py b/Lib/test/test_unparse.py
index 3e796860cbcf2..49767dbac16d1 100644
--- a/Lib/test/test_unparse.py
+++ b/Lib/test/test_unparse.py
@@ -303,17 +303,17 @@ def files_to_test(cls):
if not item.name.startswith("bad")
]
- tests_to_run_always = {item for item in items if
- item.name in cls.run_always_files}
-
# Test limited subset of files unless the 'cpu' resource is specified.
if not test.support.is_resource_enabled("cpu"):
- items = set(random.sample(items, 10))
- # Make sure that at least tests that heavily use grammar features are
- # considered to reduce the change of missing something.
+ tests_to_run_always = {item for item in items if
+ item.name in cls.run_always_files}
+
+ items = set(random.sample(items, 10))
- items = list(items | tests_to_run_always)
+ # Make sure that at least tests that heavily use grammar features are
+ # always considered in order to reduce the chance of missing something.
+ items = list(items | tests_to_run_always)
# bpo-31174: Store the names sample to always test the same files.
# It prevents false alarms when hunting reference leaks.
More information about the Python-checkins
mailing list