[Python-checkins] bpo-35660: Fix imports in idlelib.window (GH-11434)

Miss Islington (bot) webhook-mailer at python.org
Sun Jan 6 16:13:34 EST 2019


https://github.com/python/cpython/commit/be37dbff1ce3fa2ddd9115352b31ac0f6b44c193
commit: be37dbff1ce3fa2ddd9115352b31ac0f6b44c193
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-01-06T13:13:30-08:00
summary:

bpo-35660: Fix imports in idlelib.window (GH-11434)


* bpo-35660: IDLE: Remove * import from window.py

* sys was being imported through the *, so also added an import sys.

* Update 2019-01-04-19-14-29.bpo-35660.hMxI7N.rst

Anyone who wants details can check the issue, where I added the point about the sys import bug.
(cherry picked from commit 11303dd6035a7d7f78025ce5a3e3b9bdf7380c9a)

Co-authored-by: Cheryl Sabella <cheryl.sabella at gmail.com>

files:
A Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst
M Lib/idlelib/window.py

diff --git a/Lib/idlelib/window.py b/Lib/idlelib/window.py
index b2488b28cabe..460d5b67948d 100644
--- a/Lib/idlelib/window.py
+++ b/Lib/idlelib/window.py
@@ -1,4 +1,5 @@
-from tkinter import *
+from tkinter import Toplevel, TclError
+import sys
 
 
 class WindowList:
diff --git a/Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst b/Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst
new file mode 100644
index 000000000000..1ad83fe29e14
--- /dev/null
+++ b/Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst
@@ -0,0 +1 @@
+Fix imports in idlelib.window.



More information about the Python-checkins mailing list