[Python-checkins] bpo-35847: RISC-V needs CTYPES_PASS_BY_REF_HACK (GH-11694)

Miss Islington (bot) webhook-mailer at python.org
Tue Jan 29 11:16:17 EST 2019


https://github.com/python/cpython/commit/742d768656512a469ce9571b1cbd777def7bc5ea
commit: 742d768656512a469ce9571b1cbd777def7bc5ea
branch: master
author: Andreas Schwab <schwab at linux-m68k.org>
committer: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
date: 2019-01-29T08:16:10-08:00
summary:

bpo-35847: RISC-V needs CTYPES_PASS_BY_REF_HACK (GH-11694)



This fixes the ctypes.test.test_structures.StructureTestCase test.


https://bugs.python.org/issue35847

files:
A Misc/NEWS.d/next/Library/2019-01-29-09-11-09.bpo-35847.eiSi4t.rst
M Modules/_ctypes/callproc.c

diff --git a/Misc/NEWS.d/next/Library/2019-01-29-09-11-09.bpo-35847.eiSi4t.rst b/Misc/NEWS.d/next/Library/2019-01-29-09-11-09.bpo-35847.eiSi4t.rst
new file mode 100644
index 000000000000..e3775f96f36e
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2019-01-29-09-11-09.bpo-35847.eiSi4t.rst
@@ -0,0 +1 @@
+RISC-V needed the CTYPES_PASS_BY_REF_HACK.  Fixes ctypes Structure test_pass_by_value.
diff --git a/Modules/_ctypes/callproc.c b/Modules/_ctypes/callproc.c
index a7965c19b70c..bed536402023 100644
--- a/Modules/_ctypes/callproc.c
+++ b/Modules/_ctypes/callproc.c
@@ -1058,7 +1058,7 @@ GetComError(HRESULT errcode, GUID *riid, IUnknown *pIunk)
 #endif
 
 #if (defined(__x86_64__) && (defined(__MINGW64__) || defined(__CYGWIN__))) || \
-    defined(__aarch64__)
+    defined(__aarch64__) || defined(__riscv)
 #define CTYPES_PASS_BY_REF_HACK
 #define POW2(x) (((x & ~(x - 1)) == x) ? x : 0)
 #define IS_PASS_BY_REF(x) (x > 8 || !POW2(x))



More information about the Python-checkins mailing list