[Python-checkins] bpo-37558: Shared memory tests are failing due to double slashes (GH-14703)

Miss Islington (bot) webhook-mailer at python.org
Thu Jul 11 14:38:59 EDT 2019


https://github.com/python/cpython/commit/3d58b78481e0238593f85cc182b798fe3b77648c
commit: 3d58b78481e0238593f85cc182b798fe3b77648c
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-07-11T11:38:37-07:00
summary:

bpo-37558: Shared memory tests are failing due to double slashes (GH-14703)


With the addition of shared memory into Python 3.8, we now have three tests failing on Solaris, namely `test_multiprocessing_fork`, `test_multiprocessing_forkserver` and `test_multiprocessing_spawn`. The reason seems to be incorrect name handling which results in two slashes being prepended.

https://bugs.python.org/issue37558
(cherry picked from commit 4737265622251756a9480ab84af2442b6b986850)

Co-authored-by: Jakub Kulík <Kulikjak at gmail.com>

files:
A Misc/NEWS.d/next/Tests/2019-07-11-10-33-56.bpo-37558.SKHRsL.rst
M Lib/test/_test_multiprocessing.py

diff --git a/Lib/test/_test_multiprocessing.py b/Lib/test/_test_multiprocessing.py
index 9a39f385952f..2fe0def2bcd2 100644
--- a/Lib/test/_test_multiprocessing.py
+++ b/Lib/test/_test_multiprocessing.py
@@ -3990,7 +3990,7 @@ def test_shared_memory_cleaned_after_process_termination(self):
 
             # Create a shared_memory segment, and send the segment name
             sm = shared_memory.SharedMemory(create=True, size=10)
-            sys.stdout.write(sm._name + '\\n')
+            sys.stdout.write(sm.name + '\\n')
             sys.stdout.flush()
             time.sleep(100)
         '''
diff --git a/Misc/NEWS.d/next/Tests/2019-07-11-10-33-56.bpo-37558.SKHRsL.rst b/Misc/NEWS.d/next/Tests/2019-07-11-10-33-56.bpo-37558.SKHRsL.rst
new file mode 100644
index 000000000000..9f393d71a3f2
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2019-07-11-10-33-56.bpo-37558.SKHRsL.rst
@@ -0,0 +1 @@
+Fix test_shared_memory_cleaned_after_process_termination name handling



More information about the Python-checkins mailing list