[Python-checkins] Fix publishing of Windows release (GH-15006)

[Miss Islington (bot)]

https://github.com/python/cpython/commit/494ed69bcf53975b7329de3761ca3cb261419422
commit: 494ed69bcf53975b7329de3761ca3cb261419422
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-07-29T11:41:37-07:00
summary:

Fix publishing of Windows release (GH-15006)

(cherry picked from commit fe330fc4ad3b8218a84216a824af7d7007dcb85b)

Co-authored-by: Steve Dower <steve.dower at python.org>

files:
M .azure-pipelines/windows-release/stage-publish-nugetorg.yml
M Tools/msi/uploadrelease.ps1

diff --git a/.azure-pipelines/windows-release/stage-publish-nugetorg.yml b/.azure-pipelines/windows-release/stage-publish-nugetorg.yml
index 296eb28648b9..570cdb3ec57f 100644
--- a/.azure-pipelines/windows-release/stage-publish-nugetorg.yml
+++ b/.azure-pipelines/windows-release/stage-publish-nugetorg.yml
@@ -36,6 +36,6 @@ jobs:
     condition: and(succeeded(), eq(variables['SigningCertificate'], variables['__RealSigningCertificate']))
     inputs:
       command: push
-      packagesToPush: $(Build.BinariesDirectory)\nuget\*.nupkg'
+      packagesToPush: '$(Build.BinariesDirectory)\nuget\*.nupkg'
       nuGetFeedType: external
       publishFeedCredentials: 'Python on Nuget'
diff --git a/Tools/msi/uploadrelease.ps1 b/Tools/msi/uploadrelease.ps1
index 469a96818a1f..d3673b458298 100644
--- a/Tools/msi/uploadrelease.ps1
+++ b/Tools/msi/uploadrelease.ps1
@@ -92,6 +92,7 @@ if (-not $skipupload) {
     & $plink -batch $user@$server chgrp downloads $d
     & $plink -batch $user@$server chmod g-x,o+rx $d
     & $pscp -batch $chm.FullName "$user@${server}:$d"
+    if (-not $?) { throw "Failed to upload $chm" }
 
     $dirs = gci "$build" -Directory
     if ($embed) {
@@ -107,6 +108,7 @@ if (-not $skipupload) {
 
         if ($exe) {
             & $pscp -batch $exe.FullName "$user@${server}:$d"
+            if (-not $?) { throw "Failed to upload $exe" }
         }
 
         if ($msi) {
@@ -115,6 +117,7 @@ if (-not $skipupload) {
             & $plink -batch $user@$server chgrp downloads $sd
             & $plink -batch $user@$server chmod g-x,o+rx $sd
             & $pscp -batch $msi.FullName "$user@${server}:$sd"
+            if (-not $?) { throw "Failed to upload $msi" }
             & $plink -batch $user@$server chgrp downloads $sd*
             & $plink -batch $user@$server chmod g-x,o+r $sd*
         }
@@ -122,6 +125,7 @@ if (-not $skipupload) {
 
     & $plink -batch $user@$server chgrp downloads $d*
     & $plink -batch $user@$server chmod g-x,o+r $d*
+    & $pscp -ls "$user@${server}:$d"
 }
 
 if (-not $skippurge) {