[Python-checkins] bpo-37201: fix test_distutils failures for Windows ARM64 (GH-13902)
Miss Islington (bot)
webhook-mailer at python.org
Wed Jun 12 13:44:51 EDT 2019
https://github.com/python/cpython/commit/bb3e8a68b2554b2bd94cf0cd9a0311f4561c1a25
commit: bb3e8a68b2554b2bd94cf0cd9a0311f4561c1a25
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-06-12T10:44:29-07:00
summary:
bpo-37201: fix test_distutils failures for Windows ARM64 (GH-13902)
(cherry picked from commit daf62627518ad97ce66a48c49496aa0573cf0731)
Co-authored-by: Paul Monson <paulmon at users.noreply.github.com>
files:
M Lib/distutils/_msvccompiler.py
M Lib/distutils/tests/test_bdist_wininst.py
M Lib/distutils/util.py
M Lib/sysconfig.py
M PC/pyconfig.h
diff --git a/Lib/distutils/_msvccompiler.py b/Lib/distutils/_msvccompiler.py
index c7ac3f049ebf..6e14f330d7f4 100644
--- a/Lib/distutils/_msvccompiler.py
+++ b/Lib/distutils/_msvccompiler.py
@@ -93,6 +93,7 @@ def _find_vc2017():
'x86' : 'x86',
'x86_amd64' : 'x64',
'x86_arm' : 'arm',
+ 'x86_arm64' : 'arm64'
}
def _find_vcvarsall(plat_spec):
@@ -190,6 +191,7 @@ def _find_exe(exe, paths=None):
'win32' : 'x86',
'win-amd64' : 'x86_amd64',
'win-arm32' : 'x86_arm',
+ 'win-arm64' : 'x86_arm64'
}
# A set containing the DLLs that are guaranteed to be available for
diff --git a/Lib/distutils/tests/test_bdist_wininst.py b/Lib/distutils/tests/test_bdist_wininst.py
index 4c19bbab219b..163f1cc97bf9 100644
--- a/Lib/distutils/tests/test_bdist_wininst.py
+++ b/Lib/distutils/tests/test_bdist_wininst.py
@@ -1,10 +1,14 @@
"""Tests for distutils.command.bdist_wininst."""
+import sys
+import platform
import unittest
from test.support import run_unittest
from distutils.command.bdist_wininst import bdist_wininst
from distutils.tests import support
+ at unittest.skipIf(sys.platform == 'win32' and platform.machine() == 'ARM64',
+ 'bdist_wininst is not supported in this install')
@unittest.skipIf(getattr(bdist_wininst, '_unsupported', False),
'bdist_wininst is not supported in this install')
class BuildWinInstTestCase(support.TempdirManager,
diff --git a/Lib/distutils/util.py b/Lib/distutils/util.py
index 50550e189341..17a94bc42832 100644
--- a/Lib/distutils/util.py
+++ b/Lib/distutils/util.py
@@ -40,6 +40,8 @@ def get_host_platform():
return 'win-amd64'
if '(arm)' in sys.version.lower():
return 'win-arm32'
+ if '(arm64)' in sys.version.lower():
+ return 'win-arm64'
return sys.platform
# Set for cross builds explicitly
diff --git a/Lib/sysconfig.py b/Lib/sysconfig.py
index 8446c8deb242..e76e6927cb1f 100644
--- a/Lib/sysconfig.py
+++ b/Lib/sysconfig.py
@@ -628,6 +628,8 @@ def get_platform():
return 'win-amd64'
if '(arm)' in sys.version.lower():
return 'win-arm32'
+ if '(arm64)' in sys.version.lower():
+ return 'win-arm64'
return sys.platform
if os.name != "posix" or not hasattr(os, 'uname'):
diff --git a/PC/pyconfig.h b/PC/pyconfig.h
index a74ee98a753d..3d7425a5a2c1 100644
--- a/PC/pyconfig.h
+++ b/PC/pyconfig.h
@@ -122,13 +122,13 @@ WIN32 is still required for the locale module.
#if defined(_M_X64) || defined(_M_AMD64)
#if defined(__INTEL_COMPILER)
#define COMPILER ("[ICC v." _Py_STRINGIZE(__INTEL_COMPILER) " 64 bit (amd64) with MSC v." _Py_STRINGIZE(_MSC_VER) " CRT]")
-#elif defined(_M_ARM64)
-#define COMPILER _Py_PASTE_VERSION("64 bit (ARM)")
-#define PYD_PLATFORM_TAG "win_arm64"
#else
#define COMPILER _Py_PASTE_VERSION("64 bit (AMD64)")
#endif /* __INTEL_COMPILER */
#define PYD_PLATFORM_TAG "win_amd64"
+#elif defined(_M_ARM64)
+#define COMPILER _Py_PASTE_VERSION("64 bit (ARM64)")
+#define PYD_PLATFORM_TAG "win_arm64"
#else
#define COMPILER _Py_PASTE_VERSION("64 bit (Unknown)")
#endif
More information about the Python-checkins
mailing list