[Python-checkins] bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (GH-14148)

Miss Islington (bot) webhook-mailer at python.org
Mon Jun 17 06:06:57 EDT 2019

commit: a5ddbfbf50715e3d4b90ad367ed6827c6cbcc52f
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-06-17T03:06:41-07:00

bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (GH-14148)

bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD
in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the
client context.
(cherry picked from commit c034b7824f5a7c50f2946ab3931633200e31d903)

Co-authored-by: Victor Stinner <vstinner at redhat.com>

M Lib/test/test_asyncio/test_sslproto.py

diff --git a/Lib/test/test_asyncio/test_sslproto.py b/Lib/test/test_asyncio/test_sslproto.py
index 5c861e92b7d6..4645cc044a59 100644
--- a/Lib/test/test_asyncio/test_sslproto.py
+++ b/Lib/test/test_asyncio/test_sslproto.py
@@ -498,6 +498,12 @@ def test_start_tls_server_1(self):
         server_context = test_utils.simple_server_sslcontext()
         client_context = test_utils.simple_client_sslcontext()
+        if sys.platform.startswith('freebsd') or sys.platform.startswith('win'):
+            # bpo-35031: Some FreeBSD and Windows buildbots fail to run this test
+            # as the eof was not being received by the server if the payload
+            # size is not big enough. This behaviour only appears if the
+            # client is using TLS1.3.
+            client_context.options |= ssl.OP_NO_TLSv1_3
         answer = None
         def client(sock, addr):

More information about the Python-checkins mailing list