[Python-checkins] bpo-35031: also disable TLS 1.3 for test_start_tls_server_1 on macOS (GH-14188) (GH-14192)

Ned Deily webhook-mailer at python.org
Tue Jun 18 05:45:14 EDT 2019


https://github.com/python/cpython/commit/c101d1a88a8e0b0cec479307b4e0ae6866958a49
commit: c101d1a88a8e0b0cec479307b4e0ae6866958a49
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: Ned Deily <nad at python.org>
date: 2019-06-18T05:45:10-04:00
summary:

bpo-35031: also disable TLS 1.3 for test_start_tls_server_1 on macOS (GH-14188) (GH-14192)

(cherry picked from commit a514f782b822bd7bca7c8d78be7bd53bc25c1908)

Co-authored-by: Ned Deily <nad at python.org>

files:
M Lib/test/test_asyncio/test_sslproto.py

diff --git a/Lib/test/test_asyncio/test_sslproto.py b/Lib/test/test_asyncio/test_sslproto.py
index 685e3dc58e9a..866ef81fb2ee 100644
--- a/Lib/test/test_asyncio/test_sslproto.py
+++ b/Lib/test/test_asyncio/test_sslproto.py
@@ -495,11 +495,13 @@ def test_start_tls_server_1(self):
 
         server_context = test_utils.simple_server_sslcontext()
         client_context = test_utils.simple_client_sslcontext()
-        if sys.platform.startswith('freebsd') or sys.platform.startswith('win'):
+        if (sys.platform.startswith('freebsd')
+                or sys.platform.startswith('win')
+                or sys.platform.startswith('darwin')):
             # bpo-35031: Some FreeBSD and Windows buildbots fail to run this test
             # as the eof was not being received by the server if the payload
             # size is not big enough. This behaviour only appears if the
-            # client is using TLS1.3.
+            # client is using TLS1.3.  Also seen on macOS.
             client_context.options |= ssl.OP_NO_TLSv1_3
         answer = None
 



More information about the Python-checkins mailing list