[Python-checkins] [3.8] bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14473)

Benjamin Peterson webhook-mailer at python.org
Sat Jun 29 19:52:03 EDT 2019


https://github.com/python/cpython/commit/66c42f8bbcf5fa261a0d944ce8fbca9220abd11d
commit: 66c42f8bbcf5fa261a0d944ce8fbca9220abd11d
branch: 3.8
author: Benjamin Peterson <benjamin at python.org>
committer: GitHub <noreply at github.com>
date: 2019-06-29T16:51:59-07:00
summary:

[3.8] bpo-37437: Pass -Wno-unreachable-code when compiling expat. (GH-14473)

(cherry picked from commit 95da310078a9364bae9ab3f2ad9c71e34306a70c)

Co-authored-by: Benjamin Peterson <benjamin at python.org>

files:
M setup.py

diff --git a/setup.py b/setup.py
index 598f5819f8f3..edc343424297 100644
--- a/setup.py
+++ b/setup.py
@@ -1599,9 +1599,9 @@ def detect_expat_elementtree(self):
 
             cc = sysconfig.get_config_var('CC').split()[0]
             ret = os.system(
-                      '"%s" -Werror -Wimplicit-fallthrough -E -xc /dev/null >/dev/null 2>&1' % cc)
+                      '"%s" -Werror -Wno-unreachable-code -E -xc /dev/null >/dev/null 2>&1' % cc)
             if ret >> 8 == 0:
-                extra_compile_args.append('-Wno-implicit-fallthrough')
+                extra_compile_args.append('-Wno-unreachable-code')
 
         self.add(Extension('pyexpat',
                            define_macros=define_macros,



More information about the Python-checkins mailing list