[Python-checkins] bpo-36155: Check for identity on test_gc.test_get_objects (GH-12116)
Pablo Galindo
webhook-mailer at python.org
Fri Mar 1 04:12:41 EST 2019
https://github.com/python/cpython/commit/d60a79a1015aa26ff7ee3166820ec43558911b60
commit: d60a79a1015aa26ff7ee3166820ec43558911b60
branch: master
author: Pablo Galindo <Pablogsal at gmail.com>
committer: GitHub <noreply at github.com>
date: 2019-03-01T01:12:27-08:00
summary:
bpo-36155: Check for identity on test_gc.test_get_objects (GH-12116)
files:
M Lib/test/test_gc.py
diff --git a/Lib/test/test_gc.py b/Lib/test/test_gc.py
index 65e74d4759ce..2dab53004452 100644
--- a/Lib/test/test_gc.py
+++ b/Lib/test/test_gc.py
@@ -770,21 +770,45 @@ def test_get_objects(self):
gc.collect()
l = []
l.append(l)
- self.assertIn(l, gc.get_objects(generation=0))
- self.assertNotIn(l, gc.get_objects(generation=1))
- self.assertNotIn(l, gc.get_objects(generation=2))
+ self.assertTrue(
+ any(l is element for element in gc.get_objects(generation=0))
+ )
+ self.assertFalse(
+ any(l is element for element in gc.get_objects(generation=1))
+ )
+ self.assertFalse(
+ any(l is element for element in gc.get_objects(generation=2))
+ )
gc.collect(generation=0)
- self.assertNotIn(l, gc.get_objects(generation=0))
- self.assertIn(l, gc.get_objects(generation=1))
- self.assertNotIn(l, gc.get_objects(generation=2))
+ self.assertFalse(
+ any(l is element for element in gc.get_objects(generation=0))
+ )
+ self.assertTrue(
+ any(l is element for element in gc.get_objects(generation=1))
+ )
+ self.assertFalse(
+ any(l is element for element in gc.get_objects(generation=2))
+ )
gc.collect(generation=1)
- self.assertNotIn(l, gc.get_objects(generation=0))
- self.assertNotIn(l, gc.get_objects(generation=1))
- self.assertIn(l, gc.get_objects(generation=2))
+ self.assertFalse(
+ any(l is element for element in gc.get_objects(generation=0))
+ )
+ self.assertFalse(
+ any(l is element for element in gc.get_objects(generation=1))
+ )
+ self.assertTrue(
+ any(l is element for element in gc.get_objects(generation=2))
+ )
gc.collect(generation=2)
- self.assertNotIn(l, gc.get_objects(generation=0))
- self.assertNotIn(l, gc.get_objects(generation=1))
- self.assertIn(l, gc.get_objects(generation=2))
+ self.assertFalse(
+ any(l is element for element in gc.get_objects(generation=0))
+ )
+ self.assertFalse(
+ any(l is element for element in gc.get_objects(generation=1))
+ )
+ self.assertTrue(
+ any(l is element for element in gc.get_objects(generation=2))
+ )
del l
gc.collect()
More information about the Python-checkins
mailing list