[Python-checkins] Fixed typo (GH-11522)
Miss Islington (bot)
webhook-mailer at python.org
Sat May 18 05:48:53 EDT 2019
https://github.com/python/cpython/commit/561c63cd70727e92179018188a9a9c33587fbd3f
commit: 561c63cd70727e92179018188a9a9c33587fbd3f
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-05-18T02:48:47-07:00
summary:
Fixed typo (GH-11522)
Given example does not run, loop variable is missing.
Secondly, this is bad example how to handle shutdown signal, because it would cause `RuntimeError: Event loop stopped before Future completed.`
Perhaps it would be better to cancel all tasks instead of closing loop directly?
Did not create issue, because question is quite simple.
(cherry picked from commit ceb842e155f5fa0109fa88d52da3d1f5e73490ad)
Co-authored-by: Alexander Vasin <hi at alvass.in>
files:
M Doc/library/asyncio-eventloop.rst
diff --git a/Doc/library/asyncio-eventloop.rst b/Doc/library/asyncio-eventloop.rst
index b9a8b8941a46..7e1d571ef59d 100644
--- a/Doc/library/asyncio-eventloop.rst
+++ b/Doc/library/asyncio-eventloop.rst
@@ -1605,7 +1605,7 @@ using the :meth:`loop.add_signal_handler` method::
import os
import signal
- def ask_exit(signame):
+ def ask_exit(signame, loop):
print("got signal %s: exit" % signame)
loop.stop()
@@ -1615,7 +1615,7 @@ using the :meth:`loop.add_signal_handler` method::
for signame in {'SIGINT', 'SIGTERM'}:
loop.add_signal_handler(
getattr(signal, signame),
- functools.partial(ask_exit, signame))
+ functools.partial(ask_exit, signame, loop))
await asyncio.sleep(3600)
More information about the Python-checkins
mailing list