[Python-checkins] bpo-34144: Fix of venv acvtivate.bat for win 10 (GH-8321)

Miss Islington (bot) webhook-mailer at python.org
Tue May 21 11:41:48 EDT 2019


https://github.com/python/cpython/commit/3c9c2dc8dde709a5f27c74aff1614d6ed3456964
commit: 3c9c2dc8dde709a5f27c74aff1614d6ed3456964
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-05-21T08:41:44-07:00
summary:

bpo-34144: Fix of venv acvtivate.bat for win 10 (GH-8321)


The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)

https://bugs.python.org/issue34144
(cherry picked from commit 6955d44b41058e3bcc59ff41860bd4cc8948c441)

Co-authored-by: Lorenz Mende <Lorenz.mende at gmail.com>

files:
A Misc/NEWS.d/next/Windows/2019-04-10-04-35-31.bpo-34144._KzB5z.rst
M Lib/venv/scripts/nt/activate.bat

diff --git a/Lib/venv/scripts/nt/activate.bat b/Lib/venv/scripts/nt/activate.bat
index 126049f495fe..da831bb42c79 100644
--- a/Lib/venv/scripts/nt/activate.bat
+++ b/Lib/venv/scripts/nt/activate.bat
@@ -1,7 +1,7 @@
 @echo off
 
 rem This file is UTF-8 encoded, so we need to update the current code page while executing it
-for /f "tokens=2 delims=:" %%a in ('"%SystemRoot%\System32\chcp.com"') do (
+for /f "tokens=2 delims=:." %%a in ('"%SystemRoot%\System32\chcp.com"') do (
     set "_OLD_CODEPAGE=%%a"
 )
 if defined _OLD_CODEPAGE (
diff --git a/Misc/NEWS.d/next/Windows/2019-04-10-04-35-31.bpo-34144._KzB5z.rst b/Misc/NEWS.d/next/Windows/2019-04-10-04-35-31.bpo-34144._KzB5z.rst
new file mode 100644
index 000000000000..7b8ca821b401
--- /dev/null
+++ b/Misc/NEWS.d/next/Windows/2019-04-10-04-35-31.bpo-34144._KzB5z.rst
@@ -0,0 +1,2 @@
+Fixed activate.bat to correctly update codepage when chcp.com returns dots in output.
+Patch by Lorenz Mende.



More information about the Python-checkins mailing list