[Python-checkins] bpo-36994: add test for profiling method_descriptor with **kwargs (GH-13461)

Robert Collins webhook-mailer at python.org
Wed May 22 06:05:15 EDT 2019


https://github.com/python/cpython/commit/b892d3ea468101d35e2fb081002fa693bd86eca9
commit: b892d3ea468101d35e2fb081002fa693bd86eca9
branch: master
author: Jeroen Demeyer <J.Demeyer at UGent.be>
committer: Robert Collins <robertc at robertcollins.net>
date: 2019-05-22T22:05:02+12:00
summary:

bpo-36994: add test for profiling method_descriptor with **kwargs (GH-13461)

It adds a missing testcase for bpo-34125. This is testing code which is
affected by PEP 590, so missing this test might accidentally break
CPython if we screw up with implementing PEP 590.

files:
M Lib/test/test_sys_setprofile.py

diff --git a/Lib/test/test_sys_setprofile.py b/Lib/test/test_sys_setprofile.py
index b64bcbc5b686..21a09b51926e 100644
--- a/Lib/test/test_sys_setprofile.py
+++ b/Lib/test/test_sys_setprofile.py
@@ -334,6 +334,15 @@ def j(p):
                               (1, 'return', j_ident),
                               ])
 
+    # bpo-34125: profiling method_descriptor with **kwargs
+    def test_unbound_method(self):
+        kwargs = {}
+        def f(p):
+            dict.get({}, 42, **kwargs)
+        f_ident = ident(f)
+        self.check_events(f, [(1, 'call', f_ident),
+                              (1, 'return', f_ident)])
+
     # Test an invalid call (bpo-34126)
     def test_unbound_method_no_args(self):
         def f(p):



More information about the Python-checkins mailing list