[Python-checkins] bpo-21536: Fix configure.ac for LIBPYTHON on Android/Cygwin (GH-13552)

Victor Stinner webhook-mailer at python.org
Fri May 24 12:39:43 EDT 2019


https://github.com/python/cpython/commit/b1fc41784136a2eb9737a7f0c821db52ab8d4dee
commit: b1fc41784136a2eb9737a7f0c821db52ab8d4dee
branch: master
author: E. M. Bray <erik.bray at lri.fr>
committer: Victor Stinner <vstinner at redhat.com>
date: 2019-05-24T18:39:38+02:00
summary:

bpo-21536: Fix configure.ac for LIBPYTHON on Android/Cygwin (GH-13552)

Add also missing AC_MSG_RESULT for AC_MSG_CHECKING(MACHDEP).

files:
M configure
M configure.ac

diff --git a/configure b/configure
index c76eb7affe54..bc276ac58362 100755
--- a/configure
+++ b/configure
@@ -3292,6 +3292,8 @@ then
 	'')	MACHDEP="unknown";;
     esac
 fi
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: \"$MACHDEP\"" >&5
+$as_echo "\"$MACHDEP\"" >&6; }
 
 
 if test "$cross_compiling" = yes; then
@@ -15131,10 +15133,10 @@ $as_echo "$LDVERSION" >&6; }
 
 # On Android and Cygwin the shared libraries must be linked with libpython.
 
-if test -z "$ANDROID_API_LEVEL" -o "$MACHDEP" != "cygwin"; then
-  LIBPYTHON=''
-else
+if test -n "$ANDROID_API_LEVEL" -o "$MACHDEP" = "cygwin"; then
   LIBPYTHON="-lpython${VERSION}${ABIFLAGS}"
+else
+  LIBPYTHON=''
 fi
 
 
diff --git a/configure.ac b/configure.ac
index 99d99ae55c17..5e565191f27d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -411,6 +411,7 @@ then
 	'')	MACHDEP="unknown";;
     esac
 fi
+AC_MSG_RESULT("$MACHDEP")
 
 AC_SUBST(_PYTHON_HOST_PLATFORM)
 if test "$cross_compiling" = yes; then
@@ -4622,10 +4623,10 @@ AC_MSG_RESULT($LDVERSION)
 
 # On Android and Cygwin the shared libraries must be linked with libpython.
 AC_SUBST(LIBPYTHON)
-if test -z "$ANDROID_API_LEVEL" -o "$MACHDEP" != "cygwin"; then
-  LIBPYTHON=''
-else
+if test -n "$ANDROID_API_LEVEL" -o "$MACHDEP" = "cygwin"; then
   LIBPYTHON="-lpython${VERSION}${ABIFLAGS}"
+else
+  LIBPYTHON=''
 fi
 
 dnl define LIBPL after ABIFLAGS and LDVERSION is defined.



More information about the Python-checkins mailing list