[Python-checkins] Revert "bpo-38811: Check for presence of os.link method in pathlib. (GH-17170)" (#17219)

[Victor Stinner]

https://github.com/python/cpython/commit/59c80889ff3f74230a613732aacf93d4de1e0e04
commit: 59c80889ff3f74230a613732aacf93d4de1e0e04
branch: master
author: Victor Stinner <vstinner at redhat.com>
committer: GitHub <noreply at github.com>
date: 2019-11-18T12:26:37+01:00
summary:

Revert "bpo-38811: Check for presence of os.link method in pathlib. (GH-17170)" (#17219)

This reverts commit 111772fc27cfe388bc060f019d68a3e33481ec65.

files:
D Misc/NEWS.d/next/Library/2019-11-15-18-06-04.bpo-38811.AmdQ6M.rst
M Lib/pathlib.py
M Lib/test/test_pathlib.py

diff --git a/Lib/pathlib.py b/Lib/pathlib.py
index 5142ff68d100d..d70fde0ea3b45 100644
--- a/Lib/pathlib.py
+++ b/Lib/pathlib.py
@@ -418,12 +418,7 @@ def lchmod(self, pathobj, mode):
 
     unlink = os.unlink
 
-    if hasattr(os, "link"):
-        link_to = os.link
-    else:
-        @staticmethod
-        def link_to(self, target):
-            raise NotImplementedError("os.link() not available on this system")
+    link_to = os.link
 
     rmdir = os.rmdir
 
@@ -435,7 +430,6 @@ def link_to(self, target):
         if supports_symlinks:
             symlink = os.symlink
         else:
-            @staticmethod
             def symlink(a, b, target_is_directory):
                 raise NotImplementedError("symlink() not available on this system")
     else:
diff --git a/Lib/test/test_pathlib.py b/Lib/test/test_pathlib.py
index d05b956be39f3..058a201aebc1d 100644
--- a/Lib/test/test_pathlib.py
+++ b/Lib/test/test_pathlib.py
@@ -1759,7 +1759,6 @@ def test_rmdir(self):
         self.assertFileNotFound(p.stat)
         self.assertFileNotFound(p.unlink)
 
-    @unittest.skipUnless(hasattr(os, "link"), "os.link() is not present")
     def test_link_to(self):
         P = self.cls(BASE)
         p = P / 'fileA'
@@ -1779,15 +1778,6 @@ def test_link_to(self):
         self.assertEqual(os.stat(r).st_size, size)
         self.assertTrue(q.stat)
 
-    @unittest.skipIf(hasattr(os, "link"), "os.link() is present")
-    def test_link_to_not_implemented(self):
-        P = self.cls(BASE)
-        p = P / 'fileA'
-        # linking to another path.
-        q = P / 'dirA' / 'fileAA'
-        with self.assertRaises(NotImplementedError):
-            p.link_to(q)
-
     def test_rename(self):
         P = self.cls(BASE)
         p = P / 'fileA'
@@ -2021,15 +2011,6 @@ def test_symlink_to(self):
         self.assertTrue(link.is_dir())
         self.assertTrue(list(link.iterdir()))
 
-    @unittest.skipIf(support.can_symlink(), "symlink support is present")
-    def test_symlink_to_not_implemented(self):
-        P = self.cls(BASE)
-        target = P / 'fileA'
-        # Symlinking a path target.
-        link = P / 'dirA' / 'linkAA'
-        with self.assertRaises(NotImplementedError):
-            link.symlink_to(target)
-
     def test_is_dir(self):
         P = self.cls(BASE)
         self.assertTrue((P / 'dirA').is_dir())
diff --git a/Misc/NEWS.d/next/Library/2019-11-15-18-06-04.bpo-38811.AmdQ6M.rst b/Misc/NEWS.d/next/Library/2019-11-15-18-06-04.bpo-38811.AmdQ6M.rst
deleted file mode 100644
index 0e4a7f5bdf538..0000000000000
--- a/Misc/NEWS.d/next/Library/2019-11-15-18-06-04.bpo-38811.AmdQ6M.rst
+++ /dev/null
@@ -1 +0,0 @@
-Fix an unhandled exception in :mod:`pathlib` when :meth:`os.link` is missing. Patch by Toke Høiland-Jørgensen.