[Python-checkins] Remove use of deprecated `array.fromstring` method (GH-17332)

Miss Islington (bot) webhook-mailer at python.org
Tue Nov 26 03:38:47 EST 2019


https://github.com/python/cpython/commit/dadff6f6610e03a9363c52ba9c49aa923984640a
commit: dadff6f6610e03a9363c52ba9c49aa923984640a
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-11-26T00:38:41-08:00
summary:

Remove use of deprecated `array.fromstring` method (GH-17332)

(cherry picked from commit 386d00cc341b549800776b906bfc6b20ea40c7db)

Co-authored-by: David Coles <coles.david at gmail.com>

files:
M Doc/library/socket.rst
M Doc/tools/susp-ignored.csv

diff --git a/Doc/library/socket.rst b/Doc/library/socket.rst
index 12b90914bae96..ae82e43e00ff0 100644
--- a/Doc/library/socket.rst
+++ b/Doc/library/socket.rst
@@ -1394,9 +1394,9 @@ to sockets.
           fds = array.array("i")   # Array of ints
           msg, ancdata, flags, addr = sock.recvmsg(msglen, socket.CMSG_LEN(maxfds * fds.itemsize))
           for cmsg_level, cmsg_type, cmsg_data in ancdata:
-              if (cmsg_level == socket.SOL_SOCKET and cmsg_type == socket.SCM_RIGHTS):
+              if cmsg_level == socket.SOL_SOCKET and cmsg_type == socket.SCM_RIGHTS:
                   # Append data, ignoring any truncated integers at the end.
-                  fds.fromstring(cmsg_data[:len(cmsg_data) - (len(cmsg_data) % fds.itemsize)])
+                  fds.frombytes(cmsg_data[:len(cmsg_data) - (len(cmsg_data) % fds.itemsize)])
           return msg, list(fds)
 
    .. availability:: most Unix platforms, possibly others.
diff --git a/Doc/tools/susp-ignored.csv b/Doc/tools/susp-ignored.csv
index 586b5db6fcc06..33fbaf69c3fbd 100644
--- a/Doc/tools/susp-ignored.csv
+++ b/Doc/tools/susp-ignored.csv
@@ -199,7 +199,7 @@ library/readline,,:bind,"python:bind ^I rl_complete"
 library/smtplib,,:port,method must support that as well as a regular host:port
 library/socket,,::,'5aef:2b::8'
 library/socket,,:can,"return (can_id, can_dlc, data[:can_dlc])"
-library/socket,,:len,fds.fromstring(cmsg_data[:len(cmsg_data) - (len(cmsg_data) % fds.itemsize)])
+library/socket,,:len,fds.frombytes(cmsg_data[:len(cmsg_data) - (len(cmsg_data) % fds.itemsize)])
 library/sqlite3,,:age,"cur.execute(""select * from people where name_last=:who and age=:age"", {""who"": who, ""age"": age})"
 library/sqlite3,,:memory,
 library/sqlite3,,:who,"cur.execute(""select * from people where name_last=:who and age=:age"", {""who"": who, ""age"": age})"



More information about the Python-checkins mailing list