[Python-checkins] bpo-38418: Fixes audit event for os.system to be named 'os.system' (GH-16670)

Miss Islington (bot) webhook-mailer at python.org
Fri Oct 18 12:32:39 EDT 2019


https://github.com/python/cpython/commit/5fb81420d5ad64a900940e908b546cf40f2d6807
commit: 5fb81420d5ad64a900940e908b546cf40f2d6807
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-10-18T09:32:14-07:00
summary:

bpo-38418: Fixes audit event for os.system to be named 'os.system' (GH-16670)


https://bugs.python.org/issue38418

Automerge-Triggered-By: @zooba
(cherry picked from commit fbe3c76c7ce1eec887d332d801d3784212cc0f73)

Co-authored-by: Steve Dower <steve.dower at python.org>

files:
A Misc/NEWS.d/next/Security/2019-10-08-19-29-55.bpo-38418.QL7s0-.rst
M Modules/posixmodule.c

diff --git a/Misc/NEWS.d/next/Security/2019-10-08-19-29-55.bpo-38418.QL7s0-.rst b/Misc/NEWS.d/next/Security/2019-10-08-19-29-55.bpo-38418.QL7s0-.rst
new file mode 100644
index 0000000000000..b42a00047b96c
--- /dev/null
+++ b/Misc/NEWS.d/next/Security/2019-10-08-19-29-55.bpo-38418.QL7s0-.rst
@@ -0,0 +1 @@
+Fixes audit event for :func:`os.system` to be named ``os.system``.
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index b09204d63392d..7c823434e67fe 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -4316,7 +4316,7 @@ os_system_impl(PyObject *module, const Py_UNICODE *command)
 {
     long result;
 
-    if (PySys_Audit("system", "(u)", command) < 0) {
+    if (PySys_Audit("os.system", "(u)", command) < 0) {
         return -1;
     }
 
@@ -4343,7 +4343,7 @@ os_system_impl(PyObject *module, PyObject *command)
     long result;
     const char *bytes = PyBytes_AsString(command);
 
-    if (PySys_Audit("system", "(O)", command) < 0) {
+    if (PySys_Audit("os.system", "(O)", command) < 0) {
         return -1;
     }
 



More information about the Python-checkins mailing list