[Python-checkins] bpo-38090: Fix reference leak in ceval.c (GH-15848)

Steve Dower webhook-mailer at python.org
Tue Sep 10 09:32:59 EDT 2019


https://github.com/python/cpython/commit/a511c7a4961a684db1f8d0ed438822d87d7d3dcf
commit: a511c7a4961a684db1f8d0ed438822d87d7d3dcf
branch: master
author: Pablo Galindo <Pablogsal at gmail.com>
committer: Steve Dower <steve.dower at python.org>
date: 2019-09-10T14:32:54+01:00
summary:

bpo-38090: Fix reference leak in ceval.c (GH-15848)

files:
M Python/ceval.c

diff --git a/Python/ceval.c b/Python/ceval.c
index d280d7977607..01e2a1b9666f 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -5235,7 +5235,6 @@ import_from(PyThreadState *tstate, PyObject *v, PyObject *name)
     else {
         _Py_IDENTIFIER(__spec__);
         PyObject *spec = _PyObject_GetAttrId(v, &PyId___spec__);
-        Py_XINCREF(spec);
         const char *fmt =
             _PyModuleSpec_IsInitializing(spec) ?
             "cannot import name %R from partially initialized module %R "



More information about the Python-checkins mailing list