[Python-checkins] [3.8] bpo-38168: Fix a possbile refleak in setint() of mmapmodule.c (GH-16136) (GH-16174)
Miss Islington (bot)
webhook-mailer at python.org
Mon Sep 16 02:27:06 EDT 2019
https://github.com/python/cpython/commit/322309efe658122cac340adf4995ce40fa0c2e74
commit: 322309efe658122cac340adf4995ce40fa0c2e74
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-09-15T23:26:57-07:00
summary:
[3.8] bpo-38168: Fix a possbile refleak in setint() of mmapmodule.c (GH-16136) (GH-16174)
(cherry picked from commit 56a45142e70a1ccf3233d43cb60c47255252e89a)
Co-authored-by: Hai Shi <shihai1992 at gmail.com>
https://bugs.python.org/issue38168
Automerge-Triggered-By: @zhangyangyu
files:
M Modules/mmapmodule.c
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
index 9e3414f94e31..18758861a62e 100644
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -1468,7 +1468,8 @@ static void
setint(PyObject *d, const char *name, long value)
{
PyObject *o = PyLong_FromLong(value);
- if (o && PyDict_SetItemString(d, name, o) == 0) {
+ if (o) {
+ PyDict_SetItemString(d, name, o);
Py_DECREF(o);
}
}
More information about the Python-checkins
mailing list