[Python-checkins] bpo-40147: Fix a compiler warning on Windows in Python/compile.c (GH-19389)

Zackery Spytz webhook-mailer at python.org
Mon Apr 6 02:48:04 EDT 2020


https://github.com/python/cpython/commit/08050e959e6c40839cd2c9e5f6a4fd1513e3d605
commit: 08050e959e6c40839cd2c9e5f6a4fd1513e3d605
branch: master
author: Zackery Spytz <zspytz at gmail.com>
committer: GitHub <noreply at github.com>
date: 2020-04-06T07:47:47+01:00
summary:

bpo-40147: Fix a compiler warning on Windows in Python/compile.c (GH-19389)

Change the type of nkeywords to Py_ssize_t.

files:
M Python/compile.c

diff --git a/Python/compile.c b/Python/compile.c
index b1c1982fd2c4a..329add9d068ba 100644
--- a/Python/compile.c
+++ b/Python/compile.c
@@ -4050,14 +4050,15 @@ maybe_optimize_method_call(struct compiler *c, expr_ty e)
 }
 
 static int
-validate_keywords(struct compiler *c, asdl_seq* keywords) {
-    int nkeywords = asdl_seq_LEN(keywords);
-    for (int i = 0; i < nkeywords; i++) {
+validate_keywords(struct compiler *c, asdl_seq *keywords)
+{
+    Py_ssize_t nkeywords = asdl_seq_LEN(keywords);
+    for (Py_ssize_t i = 0; i < nkeywords; i++) {
         keyword_ty key = ((keyword_ty)asdl_seq_GET(keywords, i));
         if (key->arg == NULL) {
             continue;
         }
-        for (int j = i+1; j < nkeywords; j++) {
+        for (Py_ssize_t j = i + 1; j < nkeywords; j++) {
             keyword_ty other = ((keyword_ty)asdl_seq_GET(keywords, j));
             if (other->arg && !PyUnicode_Compare(key->arg, other->arg)) {
                 PyObject *msg = PyUnicode_FromFormat("keyword argument repeated: %U", key->arg);



More information about the Python-checkins mailing list