[Python-checkins] (no subject)

[Miro Hrončok]

To: python-checkins at python.org
Subject: bpo-38439: Add 256px IDLE icon (GH-17473)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

https://github.com/python/cpython/commit/3a69f3caeeaea57048ed3bc3051e16854b9a=
4cd6
commit: 3a69f3caeeaea57048ed3bc3051e16854b9a4cd6
branch: master
author: Miro Hron=C4=8Dok <miro at hroncok.cz>
committer: GitHub <noreply at github.com>
date: 2020-04-22T03:21:44-04:00
summary:

bpo-38439: Add 256px IDLE icon (GH-17473)

Icon author: Andrew Clover, bpo-1490384

files:
A Lib/idlelib/Icons/README.txt
A Lib/idlelib/Icons/idle_256.png
A Misc/NEWS.d/next/IDLE/2019-12-05-14-20-53.bpo-38439.j_L2PI.rst
D Lib/idlelib/Icons/idle.icns
M Lib/idlelib/pyshell.py
M PCbuild/lib.pyproj

diff --git a/Lib/idlelib/Icons/README.txt b/Lib/idlelib/Icons/README.txt
new file mode 100644
index 0000000000000..8b471629ecb3e
--- /dev/null
+++ b/Lib/idlelib/Icons/README.txt
@@ -0,0 +1,9 @@
+The IDLE icons are from https://bugs.python.org/issue1490384
+
+Created by Andrew Clover.
+
+The original sources are available from Andrew's website:
+https://www.doxdesk.com/software/py/pyicons.html
+
+Various different formats and sizes are available at this GitHub Pull Reques=
t:
+https://github.com/python/cpython/pull/17473
diff --git a/Lib/idlelib/Icons/idle.icns b/Lib/idlelib/Icons/idle.icns
deleted file mode 100644
index f65e3130f0aff..0000000000000
Binary files a/Lib/idlelib/Icons/idle.icns and /dev/null differ
diff --git a/Lib/idlelib/Icons/idle_256.png b/Lib/idlelib/Icons/idle_256.png
new file mode 100644
index 0000000000000..99ffa6fad4a92
Binary files /dev/null and b/Lib/idlelib/Icons/idle_256.png differ
diff --git a/Lib/idlelib/pyshell.py b/Lib/idlelib/pyshell.py
index 43fb597c2ba6e..66ae0f7435dab 100755
--- a/Lib/idlelib/pyshell.py
+++ b/Lib/idlelib/pyshell.py
@@ -1485,9 +1485,14 @@ def main():
         iconfile =3D os.path.join(icondir, 'idle.ico')
         root.wm_iconbitmap(default=3Diconfile)
     elif not macosx.isAquaTk():
-        ext =3D '.png' if TkVersion >=3D 8.6 else '.gif'
+        if TkVersion >=3D 8.6:
+            ext =3D '.png'
+            sizes =3D (16, 32, 48, 256)
+        else:
+            ext =3D '.gif'
+            sizes =3D (16, 32, 48)
         iconfiles =3D [os.path.join(icondir, 'idle_%d%s' % (size, ext))
-                     for size in (16, 32, 48)]
+                     for size in sizes]
         icons =3D [PhotoImage(master=3Droot, file=3Diconfile)
                  for iconfile in iconfiles]
         root.wm_iconphoto(True, *icons)
diff --git a/Misc/NEWS.d/next/IDLE/2019-12-05-14-20-53.bpo-38439.j_L2PI.rst b=
/Misc/NEWS.d/next/IDLE/2019-12-05-14-20-53.bpo-38439.j_L2PI.rst
new file mode 100644
index 0000000000000..de048d005cee7
--- /dev/null
+++ b/Misc/NEWS.d/next/IDLE/2019-12-05-14-20-53.bpo-38439.j_L2PI.rst
@@ -0,0 +1,2 @@
+Add a 256=C3=97256 pixel IDLE icon to support more modern environments. Crea=
ted by Andrew Clover.
+Delete the unused macOS idle.icns icon file.
diff --git a/PCbuild/lib.pyproj b/PCbuild/lib.pyproj
index d4351dec3bee2..0237b8cc85593 100644
--- a/PCbuild/lib.pyproj
+++ b/PCbuild/lib.pyproj
@@ -1585,6 +1585,7 @@
     <Content Include=3D"idlelib\Icons\idle_32.png" />
     <Content Include=3D"idlelib\Icons\idle_48.gif" />
     <Content Include=3D"idlelib\Icons\idle_48.png" />
+    <Content Include=3D"idlelib\Icons\idle_256.png" />
     <Content Include=3D"idlelib\Icons\minusnode.gif" />
     <Content Include=3D"idlelib\Icons\openfolder.gif" />
     <Content Include=3D"idlelib\Icons\plusnode.gif" />