[Python-checkins] bpo-41520: codeop no longer ignores SyntaxWarning (GH-21838)

Miss Islington (bot) webhook-mailer at python.org
Wed Aug 12 09:12:10 EDT 2020


https://github.com/python/cpython/commit/afff51fc09993dff1693aacb440221314b163409
commit: afff51fc09993dff1693aacb440221314b163409
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2020-08-12T06:12:05-07:00
summary:

bpo-41520: codeop no longer ignores SyntaxWarning (GH-21838)

(cherry picked from commit 369a1cbdee14d9f27356fb3a8bb21e4fde289d25)

Co-authored-by: Victor Stinner <vstinner at python.org>

files:
A Misc/NEWS.d/next/Library/2020-08-12-13-25-16.bpo-41520.BEUWa4.rst
M Lib/codeop.py
M Lib/test/test_codeop.py

diff --git a/Lib/codeop.py b/Lib/codeop.py
index 3c2bb6083561e..97043877d1869 100644
--- a/Lib/codeop.py
+++ b/Lib/codeop.py
@@ -84,9 +84,11 @@ def _maybe_compile(compiler, source, filename, symbol):
     except SyntaxError as err:
         pass
 
-    # Suppress warnings after the first compile to avoid duplication.
+    # Catch syntax warnings after the first compile
+    # to emit SyntaxWarning at most once.
     with warnings.catch_warnings():
-        warnings.simplefilter("ignore")
+        warnings.simplefilter("error", SyntaxWarning)
+
         try:
             code1 = compiler(source + "\n", filename, symbol)
         except SyntaxError as e:
diff --git a/Lib/test/test_codeop.py b/Lib/test/test_codeop.py
index 1e57ab9d51e2c..1eae26b6ce17e 100644
--- a/Lib/test/test_codeop.py
+++ b/Lib/test/test_codeop.py
@@ -3,6 +3,7 @@
    Nick Mathewson
 """
 import unittest
+import warnings
 from test import support
 
 from codeop import compile_command, PyCF_DONT_IMPLY_DEDENT
@@ -300,5 +301,11 @@ def test_warning(self):
             compile_command("0 is 0")
             self.assertEqual(len(w.warnings), 1)
 
+        # bpo-41520: check SyntaxWarning treated as an SyntaxError
+        with self.assertRaises(SyntaxError):
+            warnings.simplefilter('error', SyntaxWarning)
+            compile_command('1 is 1\n', symbol='exec')
+
+
 if __name__ == "__main__":
     unittest.main()
diff --git a/Misc/NEWS.d/next/Library/2020-08-12-13-25-16.bpo-41520.BEUWa4.rst b/Misc/NEWS.d/next/Library/2020-08-12-13-25-16.bpo-41520.BEUWa4.rst
new file mode 100644
index 0000000000000..ca5501c2aeec0
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2020-08-12-13-25-16.bpo-41520.BEUWa4.rst
@@ -0,0 +1 @@
+Fix :mod:`codeop` regression: it no longer ignores :exc:`SyntaxWarning`.



More information about the Python-checkins mailing list