[Python-checkins] bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449)

Miss Islington (bot) webhook-mailer at python.org
Mon Feb 10 20:27:39 EST 2020


https://github.com/python/cpython/commit/c372f9b9e758a22608b8df33423b7413d224fdad
commit: c372f9b9e758a22608b8df33423b7413d224fdad
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2020-02-10T17:27:31-08:00
summary:

bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449)


Complete previous patch.
(cherry picked from commit 96ce22706735779cf8cc46eaaa5ac61359364b5a)

Co-authored-by: Terry Jan Reedy <tjreedy at udel.edu>

files:
M Lib/idlelib/NEWS.txt
M Lib/idlelib/configdialog.py

diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt
index 1fc9e0f3090f6..9cf563401259d 100644
--- a/Lib/idlelib/NEWS.txt
+++ b/Lib/idlelib/NEWS.txt
@@ -3,6 +3,8 @@ Released on 2019-12-16?
 ======================================
 
 
+bpo-39600: Remove duplicate font names from configuration list.
+
 bpo-38792: Close a shell calltip if a :exc:`KeyboardInterrupt`
 or shell restart occurs.  Patch by Zackery Spytz.
 
diff --git a/Lib/idlelib/configdialog.py b/Lib/idlelib/configdialog.py
index 7b844f00e7736..9d5c2cde04b24 100644
--- a/Lib/idlelib/configdialog.py
+++ b/Lib/idlelib/configdialog.py
@@ -606,10 +606,8 @@ def load_font_cfg(self):
         font_size = configured_font[1]
         font_bold  = configured_font[2]=='bold'
 
-        # Set editor font selection list and font_name.
-        fonts = tkFont.families(self)
-        # remove duplicated names and sort
-        fonts = sorted(set(fonts))
+        # Set sorted no-duplicate editor font selection list and font_name.
+        fonts = sorted(set(tkFont.families(self)))
         for font in fonts:
             self.fontlist.insert(END, font)
         self.font_name.set(font_name)



More information about the Python-checkins mailing list