[Python-checkins] bpo-39184: Fix incorrect return value (GH-18580)

Miss Islington (bot) webhook-mailer at python.org
Thu Feb 20 17:44:54 EST 2020


https://github.com/python/cpython/commit/d0a464e31ac67685ef8ad35ecd993f17dfd6ab35
commit: d0a464e31ac67685ef8ad35ecd993f17dfd6ab35
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2020-02-20T14:44:47-08:00
summary:

bpo-39184: Fix incorrect return value (GH-18580)


https://bugs.python.org/issue39184

Automerge-Triggered-By: @zooba
(cherry picked from commit 6c444d0dab8f06cf304263b34beb299101cef3de)

Co-authored-by: Steve Dower <steve.dower at python.org>

files:
M PC/msvcrtmodule.c

diff --git a/PC/msvcrtmodule.c b/PC/msvcrtmodule.c
index 5c06ec2621ea6..faceb03fba39d 100644
--- a/PC/msvcrtmodule.c
+++ b/PC/msvcrtmodule.c
@@ -180,7 +180,7 @@ msvcrt_open_osfhandle_impl(PyObject *module, void *handle, int flags)
     int fd;
 
     if (PySys_Audit("msvcrt.open_osfhandle", "Ki", handle, flags) < 0) {
-        return NULL;
+        return -1;
     }
 
     _Py_BEGIN_SUPPRESS_IPH



More information about the Python-checkins mailing list