[Python-checkins] bpo-27973 - Use test.support.temp_dir instead of NamedTemporaryFile for the (#17774)

Senthil Kumaran webhook-mailer at python.org
Fri Jan 3 21:14:23 EST 2020

commit: 5bba60290b4ac8c95ac46cfdaba5deee37be1fab
branch: 2.7
author: Senthil Kumaran <senthil at uthcode.com>
committer: GitHub <noreply at github.com>
date: 2020-01-03T18:14:18-08:00

bpo-27973 - Use test.support.temp_dir instead of NamedTemporaryFile for the (#17774)

desired behavior under windows platform.

Suggestion by David Bolen

M Lib/test/test_urllibnet.py

diff --git a/Lib/test/test_urllibnet.py b/Lib/test/test_urllibnet.py
index df118dc75d1b3..ef33e3a0ea617 100644
--- a/Lib/test/test_urllibnet.py
+++ b/Lib/test/test_urllibnet.py
@@ -1,4 +1,3 @@
-import tempfile
 import unittest
 from test import test_support
 from test.test_urllib2net import skip_ftp_test_on_travis
@@ -224,9 +223,10 @@ def test_multiple_ftp_retrieves(self):
         with test_support.transient_internet(self.FTP_TEST_FILE):
-                for _ in range(self.NUM_FTP_RETRIEVES):
-                    with tempfile.NamedTemporaryFile() as fp:
-                        urllib.FancyURLopener().retrieve(self.FTP_TEST_FILE, fp.name)
+                for file_num in range(self.NUM_FTP_RETRIEVES):
+                    with test_support.temp_dir() as td:
+                        urllib.FancyURLopener().retrieve(self.FTP_TEST_FILE,
+                                                         os.path.join(td, str(file_num)))
             except IOError as e:
                 self.fail("Failed FTP retrieve while accessing ftp url "
                           "multiple times.\n Error message was : %s" % e)

More information about the Python-checkins mailing list