[Python-checkins] Fix host in address of socket.create_server example. (GH-17706)

Miss Islington (bot) webhook-mailer at python.org
Sat Jan 11 00:39:05 EST 2020


https://github.com/python/cpython/commit/0f40482fde59ff307569fa5676183dd8432809a8
commit: 0f40482fde59ff307569fa5676183dd8432809a8
branch: 3.8
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2020-01-10T21:39:01-08:00
summary:

Fix host in address of socket.create_server example. (GH-17706)


Host as None in address raises TypeError since it should be string, bytes or bytearray.
(cherry picked from commit 43682f1e39a3c61f0e8a638b887bcdcbfef766c5)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi at gmail.com>

files:
M Lib/socket.py

diff --git a/Lib/socket.py b/Lib/socket.py
index 5b17906ef479a..f83f36d0ada55 100644
--- a/Lib/socket.py
+++ b/Lib/socket.py
@@ -843,7 +843,7 @@ def create_server(address, *, family=AF_INET, backlog=None, reuse_port=False,
     connections. When false it will explicitly disable this option on
     platforms that enable it by default (e.g. Linux).
 
-    >>> with create_server((None, 8000)) as server:
+    >>> with create_server(('', 8000)) as server:
     ...     while True:
     ...         conn, addr = server.accept()
     ...         # handle new connection



More information about the Python-checkins mailing list