[Python-checkins] bpo-32989: IDLE - remove unneeded parameter (GH-18138)

Miss Islington (bot) webhook-mailer at python.org
Thu Jan 23 00:13:05 EST 2020


https://github.com/python/cpython/commit/36968c13cb9800559dbb90686933da7daf52c788
commit: 36968c13cb9800559dbb90686933da7daf52c788
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2020-01-22T21:12:58-08:00
summary:

bpo-32989: IDLE - remove unneeded parameter  (GH-18138)


IDLE does not pass a non-default _synchre in any of its calls to
pyparse.find_good_parse_start.
(cherry picked from commit f9e07e116c32b6dc4561d0bdeb452ccde13b0e7c)

Co-authored-by: Terry Jan Reedy <tjreedy at udel.edu>

files:
M Lib/idlelib/NEWS.txt
M Lib/idlelib/pyparse.py

diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt
index 379e8c102d948..f3c3cbad5a98f 100644
--- a/Lib/idlelib/NEWS.txt
+++ b/Lib/idlelib/NEWS.txt
@@ -6,7 +6,8 @@ Released on 2019-12-16?
 bpo-39050: Make Settings dialog Help button work again.
 
 bpo-32989: Add tests for editor newline_and_indent_event method.
-Remove dead code from pyparse find_good_parse_start method.
+Remove unneeded arguments and dead code from pyparse
+find_good_parse_start method.
 
 bpo-38943: Fix autocomplete windows not always appearing on some
 systems.  Patch by Johnny Najera.
diff --git a/Lib/idlelib/pyparse.py b/Lib/idlelib/pyparse.py
index 9fa2010896071..d34872b4396e1 100644
--- a/Lib/idlelib/pyparse.py
+++ b/Lib/idlelib/pyparse.py
@@ -133,7 +133,7 @@ def set_code(self, s):
         self.code = s
         self.study_level = 0
 
-    def find_good_parse_start(self, is_char_in_string, _synchre=_synchre):
+    def find_good_parse_start(self, is_char_in_string):
         """
         Return index of a good place to begin parsing, as close to the
         end of the string as possible.  This will be the start of some



More information about the Python-checkins mailing list