[Python-checkins] bpo-37224: Improve test__xxsubinterpreters.DestroyTests (GH-18058)

Kyle Stanley webhook-mailer at python.org
Fri Jan 31 15:07:23 EST 2020


https://github.com/python/cpython/commit/f03a8f8d5001963ad5b5b28dbd95497e9cc15596
commit: f03a8f8d5001963ad5b5b28dbd95497e9cc15596
branch: master
author: Kyle Stanley <aeros167 at gmail.com>
committer: GitHub <noreply at github.com>
date: 2020-01-31T12:07:09-08:00
summary:

bpo-37224: Improve test__xxsubinterpreters.DestroyTests (GH-18058)



Adds an additional assertion check based on a race condition for `test__xxsubinterpreters.DestroyTests.test_still_running` discovered in the bpo issue.


https://bugs.python.org/issue37224

files:
M Lib/test/test__xxsubinterpreters.py

diff --git a/Lib/test/test__xxsubinterpreters.py b/Lib/test/test__xxsubinterpreters.py
index 207b5db5d8fb9..30f8f98acc9dd 100644
--- a/Lib/test/test__xxsubinterpreters.py
+++ b/Lib/test/test__xxsubinterpreters.py
@@ -759,7 +759,11 @@ def test_still_running(self):
         main, = interpreters.list_all()
         interp = interpreters.create()
         with _running(interp):
-            with self.assertRaises(RuntimeError):
+            self.assertTrue(interpreters.is_running(interp),
+                            msg=f"Interp {interp} should be running before destruction.")
+
+            with self.assertRaises(RuntimeError,
+                                   msg=f"Should not be able to destroy interp {interp} while it's still running."):
                 interpreters.destroy(interp)
             self.assertTrue(interpreters.is_running(interp))
 



More information about the Python-checkins mailing list