[Python-checkins] bpo-39580: add check for CLI installation on macOS (GH-20271)
Rick Heil
webhook-mailer at python.org
Thu Jun 25 06:37:45 EDT 2020
https://github.com/python/cpython/commit/5f190d2cc60cd82a604cbffb58b6ca8f40350a7a
commit: 5f190d2cc60cd82a604cbffb58b6ca8f40350a7a
branch: master
author: Rick Heil <rickheil at partnersandsimons.com>
committer: GitHub <noreply at github.com>
date: 2020-06-25T06:37:40-04:00
summary:
bpo-39580: add check for CLI installation on macOS (GH-20271)
Adds a simple check for whether or not the package is being installed in the GUI or using installer on the command line. This addresses an issue where CLI-based software management tools (such as Munki) unexpectedly open Finder windows into a GUI session during installation runs.
files:
A Misc/NEWS.d/next/macOS/2020-06-25-06-09-00.bpo-39580.N_vJ9h.rst
M Mac/BuildScript/scripts/postflight.documentation
diff --git a/Mac/BuildScript/scripts/postflight.documentation b/Mac/BuildScript/scripts/postflight.documentation
index 3cbbc1bf10ca2..ec48599cba76e 100755
--- a/Mac/BuildScript/scripts/postflight.documentation
+++ b/Mac/BuildScript/scripts/postflight.documentation
@@ -12,7 +12,9 @@ SHARE_DOCDIR_TO_FWK="../../.."
# make link in /Applications/Python m.n/ for Finder users
if [ -d "${APPDIR}" ]; then
ln -fhs "${FWK_DOCDIR}/index.html" "${APPDIR}/Python Documentation.html"
- open "${APPDIR}" || true # open the applications folder
+ if [ "${COMMAND_LINE_INSTALL}" != 1 ]; then
+ open "${APPDIR}" || true # open the applications folder
+ fi
fi
# make share/doc link in framework for command line users
diff --git a/Misc/NEWS.d/next/macOS/2020-06-25-06-09-00.bpo-39580.N_vJ9h.rst b/Misc/NEWS.d/next/macOS/2020-06-25-06-09-00.bpo-39580.N_vJ9h.rst
new file mode 100644
index 0000000000000..95d65359804d0
--- /dev/null
+++ b/Misc/NEWS.d/next/macOS/2020-06-25-06-09-00.bpo-39580.N_vJ9h.rst
@@ -0,0 +1,2 @@
+Avoid opening Finder window if running installer from the command line.
+Patch contributed by Rick Heil.
More information about the Python-checkins
mailing list