[Python-checkins] Disable peg generator tests when building with PGO (GH-23141)

pablogsal webhook-mailer at python.org
Wed Nov 4 18:01:24 EST 2020


https://github.com/python/cpython/commit/100964e0310d3a2040d0db976f7984d0507b2dbd
commit: 100964e0310d3a2040d0db976f7984d0507b2dbd
branch: master
author: serge-sans-paille <serge.guelton at telecom-bretagne.eu>
committer: pablogsal <Pablogsal at gmail.com>
date: 2020-11-04T23:01:08Z
summary:

Disable peg generator tests when building with PGO (GH-23141)

Otherwise, when running the testsuite, test_peg_generator tries to compile C
code using the optimized flags and fails because it cannot find the profile
data.

files:
M Lib/test/test_peg_generator/test_c_parser.py

diff --git a/Lib/test/test_peg_generator/test_c_parser.py b/Lib/test/test_peg_generator/test_c_parser.py
index 0dffedca789c5..67bb8512118e3 100644
--- a/Lib/test/test_peg_generator/test_c_parser.py
+++ b/Lib/test/test_peg_generator/test_c_parser.py
@@ -1,3 +1,4 @@
+import sysconfig
 import textwrap
 import unittest
 from distutils.tests.support import TempdirManager
@@ -8,6 +9,11 @@
 from test.support import os_helper
 from test.support.script_helper import assert_python_ok
 
+_py_cflags_nodist = sysconfig.get_config_var('PY_CFLAGS_NODIST')
+_pgo_flag = sysconfig.get_config_var('PGO_PROF_USE_FLAG')
+if _pgo_flag and _py_cflags_nodist and _pgo_flag in _py_cflags_nodist:
+    raise unittest.SkipTest("peg_generator test disabled under PGO build")
+
 test_tools.skip_if_missing("peg_generator")
 with test_tools.imports_under_tool("peg_generator"):
     from pegen.grammar_parser import GeneratedParser as GrammarParser



More information about the Python-checkins mailing list