[Python-checkins] [3.9] bpo-39481: Fix duplicate SimpleQueue type in test_genericalias.py (GH-22619) (#22624)

Saiyang Gou webhook-mailer at python.org
Mon Oct 12 19:52:12 EDT 2020


https://github.com/python/cpython/commit/1c217652b690c184b43d8e2b6529a60a14e64328
commit: 1c217652b690c184b43d8e2b6529a60a14e64328
branch: 3.9
author: Saiyang Gou <gousaiyang at 163.com>
committer: GitHub <noreply at github.com>
date: 2020-10-12T16:52:03-07:00
summary:

[3.9] bpo-39481: Fix duplicate SimpleQueue type in test_genericalias.py (GH-22619) (#22624)

There are two different `SimpleQueue` types imported (from `multiprocessing.queues` and `queue`) in `Lib/test/test_genericalias.py`, the second one shadowing the first one, making the first one not actually tested. Fix by using different names.

Automerge-Triggered-By: @gvanrossum.
(cherry picked from commit b2c0a43699bd9023a69e3fa554f5488a2e17e278)

Co-authored-by: Saiyang Gou <gousaiyang at 163.com>

files:
M Lib/test/test_genericalias.py

diff --git a/Lib/test/test_genericalias.py b/Lib/test/test_genericalias.py
index ec1acd475ce5a..240aad02518ff 100644
--- a/Lib/test/test_genericalias.py
+++ b/Lib/test/test_genericalias.py
@@ -26,7 +26,7 @@
 except ImportError:
     # multiprocessing.shared_memory is not available on e.g. Android
     ShareableList = None
-from multiprocessing.queues import SimpleQueue
+from multiprocessing.queues import SimpleQueue as MPSimpleQueue
 from os import DirEntry
 from re import Pattern, Match
 from types import GenericAlias, MappingProxyType, AsyncGeneratorType
@@ -79,7 +79,7 @@ def test_subscriptable(self):
                   SplitResult, ParseResult,
                   ValueProxy, ApplyResult,
                   WeakSet, ReferenceType, ref,
-                  ShareableList, SimpleQueue,
+                  ShareableList, MPSimpleQueue,
                   Future, _WorkItem,
                   Morsel,
                   ):



More information about the Python-checkins mailing list