[Python-checkins] Fix broken test for MutableSet.pop() (GH-25209)
rhettinger
webhook-mailer at python.org
Wed Apr 7 19:32:03 EDT 2021
https://github.com/python/cpython/commit/453074c8daf996b1815a0cd2218f0dbf1801056c
commit: 453074c8daf996b1815a0cd2218f0dbf1801056c
branch: master
author: Stepan Sindelar <me at stevesindelar.cz>
committer: rhettinger <rhettinger at users.noreply.github.com>
date: 2021-04-07T16:31:55-07:00
summary:
Fix broken test for MutableSet.pop() (GH-25209)
Changes the test to not assert concrete result of pop, but just that it
was an item from the set, and that the set shrunk by one.
files:
M Lib/test/test_collections.py
diff --git a/Lib/test/test_collections.py b/Lib/test/test_collections.py
index 30303f00ba5c1..7b245c08b5ddd 100644
--- a/Lib/test/test_collections.py
+++ b/Lib/test/test_collections.py
@@ -1512,8 +1512,12 @@ def discard(self,v):
return result
def __repr__(self):
return "MySet(%s)" % repr(list(self))
- s = MySet([5,43,2,1])
- self.assertEqual(s.pop(), 1)
+ items = [5,43,2,1]
+ s = MySet(items)
+ r = s.pop()
+ self.assertEquals(len(s), len(items) - 1)
+ self.assertNotIn(r, s)
+ self.assertIn(r, items)
def test_issue8750(self):
empty = WithSet()
More information about the Python-checkins
mailing list