[Python-checkins] bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio (GH-27870)

miss-islington webhook-mailer at python.org
Sat Aug 21 16:30:17 EDT 2021


https://github.com/python/cpython/commit/88a1920c7b7b0fb73c4037b460c6a4a8c0aa10f0
commit: 88a1920c7b7b0fb73c4037b460c6a4a8c0aa10f0
branch: 3.10
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2021-08-21T13:30:08-07:00
summary:

bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio (GH-27870)


The code of the test was never executed because the test function
was unintentionally converted to a generator function.
(cherry picked from commit 585390fdd8661b4bc08bdfc27551292da9b4b9b8)

Co-authored-by: Serhiy Storchaka <storchaka at gmail.com>

files:
M Lib/test/test_asyncio/test_events.py

diff --git a/Lib/test/test_asyncio/test_events.py b/Lib/test/test_asyncio/test_events.py
index 55fc266cb714b1..778dd43f68848a 100644
--- a/Lib/test/test_asyncio/test_events.py
+++ b/Lib/test/test_asyncio/test_events.py
@@ -1970,10 +1970,11 @@ def test_subprocess_wait_no_same_group(self):
                         functools.partial(MySubprocessProtocol, self.loop),
                         'exit 7', stdin=None, stdout=None, stderr=None,
                         start_new_session=True)
-        _, proto = yield self.loop.run_until_complete(connect)
+        transp, proto = self.loop.run_until_complete(connect)
         self.assertIsInstance(proto, MySubprocessProtocol)
         self.loop.run_until_complete(proto.completed)
         self.assertEqual(7, proto.returncode)
+        transp.close()
 
     def test_subprocess_exec_invalid_args(self):
         async def connect(**kwds):



More information about the Python-checkins mailing list