[Python-checkins] bpo-44753: Don't use logfile extension when determining old files to be deleted (GH-27475)

vsajip webhook-mailer at python.org
Fri Jul 30 07:48:59 EDT 2021


https://github.com/python/cpython/commit/6ff890380971752299325bd28eab80ec936975cf
commit: 6ff890380971752299325bd28eab80ec936975cf
branch: main
author: Vinay Sajip <vinay_sajip at yahoo.co.uk>
committer: vsajip <vinay_sajip at yahoo.co.uk>
date: 2021-07-30T12:48:50+01:00
summary:

bpo-44753: Don't use logfile extension when determining old files to be deleted (GH-27475)

files:
M Lib/logging/handlers.py

diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index 9506b9acdd4fa3..e2579db58046df 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -359,7 +359,8 @@ def getFilesToDelete(self):
         dirName, baseName = os.path.split(self.baseFilename)
         fileNames = os.listdir(dirName)
         result = []
-        prefix = baseName + "."
+        # See bpo-44753: Don't use the extension when computing the prefix.
+        prefix = os.path.splitext(baseName)[0] + "."
         plen = len(prefix)
         for fileName in fileNames:
             if fileName[:plen] == prefix:



More information about the Python-checkins mailing list